Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let workflow not trigger on labels #58

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: let workflow not trigger on labels #58

merged 2 commits into from
Sep 18, 2024

Conversation

JTaeuber
Copy link
Member

@JTaeuber JTaeuber commented Sep 17, 2024

Motivation

The check for release workflow triggered the warning message multiple times when you created labels beforehand.

Changes

Changed the if check for the job.

Tests done

I tested this here.
Now it always adds the needs approval label if it was removed without writing the message again for labeling and unlabeling.

@JTaeuber JTaeuber added enhancement New feature or request housekeeping A change that cleans or updates the repository. labels Sep 17, 2024
@JTaeuber JTaeuber added the bug Something isn't working label Sep 17, 2024
jonathan-mayer
jonathan-mayer previously approved these changes Sep 17, 2024
Copy link
Member

@jonathan-mayer jonathan-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLikeItWillProbablyWorkTM

@JTaeuber JTaeuber merged commit 2c66e80 into main Sep 18, 2024
4 checks passed
@JTaeuber JTaeuber deleted the Fix/NoMsgOnLabel branch September 18, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request housekeeping A change that cleans or updates the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants