Chore/minimize metrics #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Bressi <[email protected]>
The grafana metrics were not being scraped because of the missing label Signed-off-by: Bruno Bressi <[email protected]>
Reverted to rc status again to test grafana smon Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
|
still LGTM 😄 |
This common label is expected to be present in general in the prometheus components of the caas-cluster-monitoring stack and so it should also be part of the kube-prometheus stack, so that serviceMonitors and other objects can be picked out-of-the-box Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
|
Haha @CerRegulus thanks for the new review. I'm updating the chart to also include some minor fixes (missing grafana metrics, prometheus was missing the @JTaeuber the dashboards look OK. We'll be merging this week I think 👍 |
Signed-off-by: Bruno Bressi <[email protected]>
They are not passed down to prometheus pods Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
puffitos
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Relates to this issue.
Changes
Wrote a regex to keep only the metrics we're using in our dashboards for the
rkeControllerManager,rkeProxyandrkeScheduler.Tests done