New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version detection #4168

Merged

leijurv merged 2 commits into cabaletta:1.19.4 from ZacSharp:pr/build/1.19.4/improvedVersionDetection

Oct 31, 2023

Collaborator

ZacSharp commented Oct 26, 2023 •

edited

Loading

No longer uses tags from merged-in branches. E.g. the head commit of this pr is "v1.9.2-22-g9accb2bfb" instead of "v1.2.19-572-g9accb2bfb". (Note: CI builds use "v1.9.3-something" because CI runs on a temporary merge commit)
No longer crashes if git is not installed.

ZacSharp added 2 commits

October 26, 2023 21:19


          Slightly better version strings

20d62c6


          Don't crash the build if git is not available

9accb2b

Member

leijurv commented Oct 31, 2023

Ooh, thank you so much! This was bugging me lol

leijurv merged commit ea964a9 into cabaletta:1.19.4

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet