Allow walking on soul sand once again #4531
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, had a branch checked out when I started this... |
ZacSharp
force-pushed
the
pr/1.19.4/pathing/canWalkOnSoulSand
branch
from
46f8786 to
991d822
Compare
|
wow that's brutal, I had no idea |
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like at some point soul sand stopped being a normal cube (I think they lowered it's collision height?) so we need a special case to walk over it.
No consideration was given to where in the if-else chain the new check should be placed.
Fixes #4497
Closes #2795
Fixes #1550
Closes #1877