1.21.3 #4536
1.21.3 #4536
Conversation
|
should be rebased on #4534 after that's merged |
| } | ||
| Tool toolComponent = itemStack.get(DataComponents.TOOL); | ||
| if (toolComponent == null) return -1; | ||
| return toolComponent.damagePerBlock(); // todo: i have no idea what "material cost" means anymore |
There was a problem hiding this comment.
It's supposed to be a rough estimate how valuable the tool is. Just so if you happen to have two equally fast tools, Baritone will pick the cheaper one.
There was a problem hiding this comment.
gotcha, that makes more sense.
i think there's an enchantment cost data component for something like the prev behavior then. i'll update and also add clarifying comment about what this "cost" means
| * <p> | ||
| * If below 1000L (1sec), it's better to disable this | ||
| */ | ||
| public final Setting<Long> toastTimer = new Setting<>(5000L); |
There was a problem hiding this comment.
Not needed/possible anymore?
There was a problem hiding this comment.
probably possible but the timer is encoded as a final field in SystemToastId
so we'd have to revert back to implementing a custom Toast subclass or do some other hack
reusing system toasts is much simpler and i don't think its worth the maintenance burden doing the alternatives
|
#4534 has been merged Edit: I'm blind |
|
And rfresh already did the rebase. |
|
Should this have a new base branch 1.21.3 or should I actually merge into 1.21.1? |
|
new base branch |
No description provided.