Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed behavior that not updates soapenv body from custom MessagePlugin #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amammi
Copy link

@amammi amammi commented Jan 31, 2024

@cackharot I've encountered the problem of updating soap request message with a custom MessagePlugin like this (it's just an example):

class HelloSOAPWorldPlugin(MessagePlugin):

    def sending(self, context: MessageContext):

        context.envelope = b'Hello World SOAP!'

the result is that request is the same and is not updated like in the custom MessagePlugin.

I've found this fix and, since I'm not familiar with this project, feel free to update this PR.

Thanks in advance.

… folder "venv".

[client.py] Fixed message plugin effects for receive eventually changes in request from message plugins.
[plugin.py] Little refactoring, adding MessageContext type in sending method of MessagePlugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant