Extract correct version when using --with flag to replace Caddy core #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following build failed on Windows with
Invalid Semantic Version
error.xcaddy build v2.8.4 --with github.com/caddyserver/caddy/v2=c:\Users\test\caddy
The bug is among lines 97 - 110 in the builder.go.
Detailed explanation:
The
go list -m
command in this case would returngithub.com/caddyserver/caddy/v2 v2.8.4 => c:\Users\test\caddy
. The value of theversion
would end up beingv2.8.4 => c:\Users\test\Documents\EyeSCADA-v4\_esRouter\caddy-2.8.4
. Therefore, theutils.WIndows Resource()
call would fail with 'Invalid Semantic Version` error.A quick fix would be adding the following between
version := ...
anderr = util.WIndowsResource(...)
: