Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for RequestMapper and DecisionMapper #922

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

natemort
Copy link
Member

What changed?

  • Add Tests for converting thrift requests to proto requests.
  • Add tests for converting thrift Decisions to proto Decisions

Why?

  • Increasing code coverage and discovering bugs

How did you test it?

  • Running the unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@c6891e2). Learn more about missing BASE report.

Additional details and impacted files

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6891e2...9f8a2a7. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2536

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+3.3%) to 65.287%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java 1 87.8%
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowMutableStateImpl.java 1 83.5%
src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java 5 80.27%
Totals Coverage Status
Change from base Build 2526: 3.3%
Covered Lines: 12733
Relevant Lines: 19503

💛 - Coveralls

@natemort natemort merged commit 760f880 into cadence-workflow:master Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants