-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added coverage for TestActivityExecutor private methods #971
Merged
3vilhamster
merged 2 commits into
cadence-workflow:master
from
3vilhamster:unsupported-methods-coverage
Nov 26, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
235 changes: 235 additions & 0 deletions
235
src/test/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternalTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,235 @@ | ||
/* | ||
Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
|
||
Modifications copyright (C) 2017 Uber Technologies, Inc. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"). You may not | ||
use this file except in compliance with the License. A copy of the License is | ||
located at | ||
|
||
http://aws.amazon.com/apache2.0 | ||
|
||
or in the "license" file accompanying this file. This file is distributed on | ||
an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
express or implied. See the License for the specific language governing | ||
permissions and limitations under the License. | ||
*/ | ||
|
||
package com.uber.cadence.internal.sync; | ||
|
||
import static org.junit.Assert.fail; | ||
import static org.mockito.Mockito.mock; | ||
|
||
import com.uber.cadence.WorkflowExecution; | ||
import com.uber.cadence.serviceclient.IWorkflowService; | ||
import com.uber.cadence.workflow.Functions; | ||
import com.uber.cadence.workflow.WorkflowInterceptorBase; | ||
import java.lang.reflect.Constructor; | ||
import java.lang.reflect.Method; | ||
import java.lang.reflect.Type; | ||
import java.time.Duration; | ||
import java.util.Map; | ||
import java.util.Optional; | ||
import java.util.function.BiPredicate; | ||
import java.util.function.Supplier; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.mockito.Mock; | ||
import org.mockito.MockitoAnnotations; | ||
|
||
public class TestActivityEnvironmentInternalTest { | ||
@Mock private IWorkflowService mockWorkflowService; | ||
|
||
@Mock private WorkflowInterceptorBase mockNext; | ||
|
||
private Object testActivityExecutor; | ||
|
||
// Helper method to find the inner class | ||
private Class<?> findTestActivityExecutorClass() { | ||
for (Class<?> declaredClass : TestActivityEnvironmentInternal.class.getDeclaredClasses()) { | ||
if (declaredClass.getSimpleName().equals("TestActivityExecutor")) { | ||
return declaredClass; | ||
} | ||
} | ||
throw new RuntimeException("Could not find TestActivityExecutor inner class"); | ||
} | ||
|
||
// Helper method to print all methods | ||
private void printMethods(Class<?> clazz) { | ||
System.out.println("Methods for " + clazz.getName() + ":"); | ||
for (Method method : clazz.getDeclaredMethods()) { | ||
System.out.println(" " + method); | ||
} | ||
} | ||
|
||
@Before | ||
public void setUp() { | ||
MockitoAnnotations.openMocks(this); | ||
|
||
try { | ||
// Find the inner class first | ||
Class<?> innerClass = findTestActivityExecutorClass(); | ||
|
||
// Get the constructor with the specific parameter types | ||
Constructor<?> constructor = | ||
innerClass.getDeclaredConstructor( | ||
TestActivityEnvironmentInternal.class, | ||
IWorkflowService.class, | ||
WorkflowInterceptorBase.class); | ||
constructor.setAccessible(true); | ||
|
||
// Create an instance of the outer class | ||
TestActivityEnvironmentInternal outerInstance = mock(TestActivityEnvironmentInternal.class); | ||
|
||
// Create the instance | ||
testActivityExecutor = constructor.newInstance(outerInstance, mockWorkflowService, mockNext); | ||
|
||
// Debug print the class and methods | ||
System.out.println("TestActivityExecutor class: " + innerClass); | ||
printMethods(innerClass); | ||
3vilhamster marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (Exception e) { | ||
e.printStackTrace(); | ||
throw new RuntimeException("Failed to set up test: " + e.getMessage(), e); | ||
} | ||
} | ||
|
||
@Test | ||
public void testAllMethodsThrowUnsupportedOperationException() throws Exception { | ||
// Define test cases for different methods | ||
MethodTestCase[] methodCases = { | ||
// Signature: newRandom() | ||
new MethodTestCase("newRandom", new Class<?>[0], new Object[0]), | ||
|
||
// Signature: signalExternalWorkflow(String, WorkflowExecution, String, Object[]) | ||
new MethodTestCase( | ||
"signalExternalWorkflow", | ||
new Class<?>[] {String.class, WorkflowExecution.class, String.class, Object[].class}, | ||
new Object[] { | ||
"testSignal", mock(WorkflowExecution.class), "signalName", new Object[] {} | ||
}), | ||
|
||
// Signature: signalExternalWorkflow(WorkflowExecution, String, Object[]) | ||
new MethodTestCase( | ||
"signalExternalWorkflow", | ||
new Class<?>[] {WorkflowExecution.class, String.class, Object[].class}, | ||
new Object[] {mock(WorkflowExecution.class), "signalName", new Object[] {}}), | ||
|
||
// Signature: cancelWorkflow(WorkflowExecution) | ||
new MethodTestCase( | ||
"cancelWorkflow", | ||
new Class<?>[] {WorkflowExecution.class}, | ||
new Object[] {mock(WorkflowExecution.class)}), | ||
|
||
// Signature: sleep(Duration) | ||
new MethodTestCase( | ||
"sleep", new Class<?>[] {Duration.class}, new Object[] {Duration.ofSeconds(1)}), | ||
|
||
// Signature: await(Duration, String, Supplier) | ||
new MethodTestCase( | ||
"await", | ||
new Class<?>[] {Duration.class, String.class, Supplier.class}, | ||
new Object[] {Duration.ofSeconds(1), "testReason", (Supplier<?>) () -> true}), | ||
|
||
// Signature: await(String, Supplier) | ||
new MethodTestCase( | ||
"await", | ||
new Class<?>[] {String.class, Supplier.class}, | ||
new Object[] {"testReason", (Supplier<?>) () -> true}), | ||
|
||
// Signature: newTimer(Duration) | ||
new MethodTestCase( | ||
"newTimer", new Class<?>[] {Duration.class}, new Object[] {Duration.ofSeconds(1)}), | ||
|
||
// Signature: sideEffect(Class, Type, Functions.Func) | ||
new MethodTestCase( | ||
"sideEffect", | ||
new Class<?>[] {Class.class, Type.class, Functions.Func.class}, | ||
new Object[] {String.class, String.class, (Functions.Func<String>) () -> "test"}), | ||
|
||
// Signature: mutableSideEffect(String, Class, Type, BiPredicate, Functions.Func) | ||
new MethodTestCase( | ||
"mutableSideEffect", | ||
new Class<?>[] { | ||
String.class, Class.class, Type.class, BiPredicate.class, Functions.Func.class | ||
}, | ||
new Object[] { | ||
"testId", | ||
String.class, | ||
String.class, | ||
(BiPredicate<String, String>) (a, b) -> false, | ||
(Functions.Func<String>) () -> "test" | ||
}), | ||
|
||
// Signature: getVersion(String, int, int) | ||
new MethodTestCase( | ||
"getVersion", | ||
new Class<?>[] {String.class, int.class, int.class}, | ||
new Object[] {"changeId", 0, 1}), | ||
|
||
// Signature: continueAsNew(Optional, Optional, Object[]) | ||
new MethodTestCase( | ||
"continueAsNew", | ||
new Class<?>[] {Optional.class, Optional.class, Object[].class}, | ||
new Object[] {Optional.empty(), Optional.empty(), new Object[] {}}), | ||
|
||
// Signature: registerQuery(String, Type[], Func1) | ||
new MethodTestCase( | ||
"registerQuery", | ||
new Class<?>[] {String.class, Type[].class, Functions.Func1.class}, | ||
new Object[] { | ||
"queryType", | ||
new Type[] {String.class}, | ||
(Functions.Func1<Object[], Object>) args -> "result" | ||
}), | ||
|
||
// Signature: randomUUID() | ||
new MethodTestCase("randomUUID", new Class<?>[0], new Object[0]), | ||
|
||
// Signature: upsertSearchAttributes(Map) | ||
new MethodTestCase( | ||
"upsertSearchAttributes", | ||
new Class<?>[] {Map.class}, | ||
new Object[] {java.util.Collections.emptyMap()}) | ||
}; | ||
|
||
// Test each method | ||
for (MethodTestCase testCase : methodCases) { | ||
try { | ||
// Find the method | ||
Method method = | ||
testActivityExecutor | ||
.getClass() | ||
.getDeclaredMethod(testCase.methodName, testCase.parameterTypes); | ||
method.setAccessible(true); | ||
|
||
// Invoke the method | ||
Object result = method.invoke(testActivityExecutor, testCase.arguments); | ||
|
||
// If we get here, the method did not throw UnsupportedOperationException | ||
fail("Expected UnsupportedOperationException for method " + testCase.methodName); | ||
|
||
} catch (Exception e) { | ||
// Check if the cause is UnsupportedOperationException | ||
if (!(e.getCause() instanceof UnsupportedOperationException)) { | ||
// If it's not the expected exception, rethrow | ||
throw new RuntimeException("Unexpected exception for method " + testCase.methodName, e); | ||
} | ||
// Expected behavior - UnsupportedOperationException was thrown | ||
// Continue to next method | ||
} | ||
} | ||
} | ||
|
||
// Helper class to encapsulate method test cases | ||
private static class MethodTestCase { | ||
String methodName; | ||
Class<?>[] parameterTypes; | ||
Object[] arguments; | ||
|
||
MethodTestCase(String methodName, Class<?>[] parameterTypes, Object[] arguments) { | ||
this.methodName = methodName; | ||
this.parameterTypes = parameterTypes; | ||
this.arguments = arguments; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to leave it for now since I'm trying to debug the next steps for WorkflowServiceWrapper. It looks very useful helper :)