-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the heap allocation of Displayxxxx:default() #127
Conversation
ha, fmt is very unhappy, fixing that. |
b4ab6b6
to
c719ed4
Compare
I am hearing suggestions on the esp-rs matrix:
|
ha... last minute changes... it doesn't work now:
|
44f812c
to
6918e2c
Compare
A updated the implementation to only use alloc::boxed when enabled instead of std::boxed |
If you look at #123 you can see that the Without needing |
Oh awesome, I like your approach much better then. I will give a try to your PR and report back :) |
I finally hat time to merge Peckpecks PR, so if his idea already resolves your issue, we could change this pr/make a different one where we add it to the readme as an faq point or similar and maybe to the main doc comment as well. |
I will do that @caemor ! |
Oh sorry, right it was on me to document this. |
6918e2c
to
ac2e43e
Compare
Ok, I converted it to documentation. |
51d647a
to
e4f44d7
Compare
Co-authored-by: Christoph Gross <[email protected]>
Co-authored-by: Christoph Gross <[email protected]>
df2058e
to
42414f4
Compare
Some platforms (like ESP32) have a limited stack size, but a bigger heap which can range 2-4MBytes for spiram. In such platforms it's impossible to allocate most of the displays in the stack, but it's possible to get them heap allocated (as long as we are compiling with std).
This commit documents heap allocation of the display buffer.