Merge pull request #460 from cakephp/issue-459

Generate task tests correctly.
cakephp · Aug 17, 2018 · 3c7c701 · 3c7c701
2 parents d3a75d7 + db2a029
commit 3c7c701
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/Shell/Task/TestTask.php b/src/Shell/Task/TestTask.php
@@ -542,10 +542,8 @@ public function generateConstructor($type, $fullClassName)
             $construct = "new {$className}(\$this->io);";
         }
         if ($type === 'Task') {
-            $pre = "\$this->io = \$this->getMockBuilder('Cake\Console\ConsoleIo')->getMock();\n";
-            $construct = "\$this->getMockBuilder('{$fullClassName}')\n";
-            $construct .= "            ->setConstructorArgs([\$this->io])\n";
-            $construct .= "            ->getMock();";
+            $pre = "\$this->io = \$this->getMockBuilder('Cake\Console\ConsoleIo')->getMock();";
+            $construct = "new {$className}(\$this->io);";
         }
         if ($type === 'Cell') {
             $pre = "\$this->request = \$this->getMockBuilder('Cake\Http\ServerRequest')->getMock();\n";

diff --git a/tests/comparisons/Test/testBakeShellTaskTest.php b/tests/comparisons/Test/testBakeShellTaskTest.php
@@ -33,10 +33,7 @@ public function setUp()
     {
         parent::setUp();
         $this->io = $this->getMockBuilder('Cake\Console\ConsoleIo')->getMock();
-
-        $this->Articles = $this->getMockBuilder('App\Shell\Task\ArticlesTask')
-            ->setConstructorArgs([$this->io])
-            ->getMock();
+        $this->Articles = new ArticlesTask($this->io);
     }
 
     /**