Merge pull request #461 from dmromanov/bugfix/short-dummy-text-gen

Fixed dummy text generation for short text fields
cakephp · Nov 4, 2018 · d4b1a92 · d4b1a92
2 parents 7356656 + b2cd43e
commit d4b1a92
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
     },
     "require": {
         "php": ">=5.6.0",
-        "cakephp/cakephp": "^3.6.0",
+        "cakephp/cakephp": "^3.6.12",
         "cakephp/plugin-installer": "^1.0",
         "wyrihaximus/twig-view": "^4.3.4"
     },

diff --git a/src/Shell/Task/FixtureTask.php b/src/Shell/Task/FixtureTask.php
@@ -366,7 +366,7 @@ protected function _generateRecords(TableSchema $table, $recordCount = 1)
                         } else {
                             $insert = "Lorem ipsum dolor sit amet";
                             if (!empty($fieldInfo['length'])) {
-                                $insert = substr($insert, 0, (int)$fieldInfo['length'] - 2);
+                                $insert = substr($insert, 0, (int)$fieldInfo['length'] > 2 ? (int)$fieldInfo['length'] - 2 : (int)$fieldInfo['length']);
                             }
                         }
                         break;

diff --git a/tests/Fixture/BinaryTestsFixture.php b/tests/Fixture/BinaryTestsFixture.php
@@ -29,6 +29,7 @@ class BinaryTestsFixture extends TestFixture
      */
     public $fields = [
         'id' => ['type' => 'integer'],
+        'byte' => ['type' => 'binary', 'length' => 1],
         'data' => ['type' => 'binary', 'length' => 300],
         '_constraints' => ['primary' => ['type' => 'primary', 'columns' => ['id']]]
     ];

diff --git a/tests/TestCase/Shell/Task/FixtureTaskTest.php b/tests/TestCase/Shell/Task/FixtureTaskTest.php
@@ -18,6 +18,8 @@
 use Bake\Test\TestCase\TestCase;
 use Cake\Console\Shell;
 use Cake\Core\Plugin;
+use Cake\Database\Driver\Postgres;
+use Cake\Datasource\ConnectionManager;
 use Cake\ORM\TableRegistry;
 
 /**
@@ -360,10 +362,31 @@ public function testRecordGenerationForDatatypes()
      */
     public function testRecordGenerationForBinaryType()
     {
+        $driver = ConnectionManager::get('test')->getDriver();
+        $this->skipIf($driver instanceof Postgres, 'Incompatible with postgres');
+
+        $this->generatedFile = ROOT . 'tests/Fixture/BinaryTestsFixture.php';
+        $this->exec('bake fixture --connection test BinaryTests');
+
+        $this->assertFileContains("'data' => 'Lorem ipsum dolor sit amet'", $this->generatedFile);
+        $this->assertFileContains("'byte' => 'L'", $this->generatedFile);
+    }
+
+    /**
+     * test record generation with float and binary types
+     *
+     * @return void
+     */
+    public function testRecordGenerationForBinaryTypePostgres()
+    {
+        $driver = ConnectionManager::get('test')->getDriver();
+        $this->skipIf(($driver instanceof Postgres) === false, 'Only compatible with postgres');
+
         $this->generatedFile = ROOT . 'tests/Fixture/BinaryTestsFixture.php';
         $this->exec('bake fixture --connection test BinaryTests');
 
         $this->assertFileContains("'data' => 'Lorem ipsum dolor sit amet'", $this->generatedFile);
+        $this->assertFileContains("'byte' => 'Lorem ipsum dolor sit amet'", $this->generatedFile);
     }
 
     /**