Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make method annotations more strict #1010

Closed
wants to merge 4 commits into from
Closed

Conversation

Harfusha
Copy link

@dereuromark
Copy link
Member

dereuromark commented Oct 14, 2024

The original issue reported was

> newEntity() parameter #1 $data with no value type specified in iterable type array.

None of the concrete entity changes is addressing it.
The opposite: this is usually rather creating more problems for App level.

Can we just fix the mixed in iterable instead?

@dereuromark
Copy link
Member

dereuromark commented Oct 14, 2024

I would expect

iterable<EntityInterface>

For input args (param) annotation

And concrete entity for output (return) annotation

@Harfusha
Copy link
Author

Oh, so you want to implement the concete entities in IdeHelper?
Going to fix the issues.

dereuromark
dereuromark previously approved these changes Oct 14, 2024
Copy link
Member

@dereuromark dereuromark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dereuromark dereuromark dismissed their stale review October 16, 2024 11:10

It turns out most IDEs are not yet understanding this new syntax. Maybe this should rather be an opt-in feature flag for IdeHelper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants