Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModelCommand.php #1017

Closed
wants to merge 1 commit into from
Closed

Conversation

luizcmarin
Copy link
Contributor

@luizcmarin luizcmarin commented Nov 23, 2024

ref: #1015

Just look, I imagine something like this.
But the generated name may seem a bit 'strange'. Lack of creativity, I think. It became 'table.RelatedTable_link_field'. For example, "$this->belongsTo('UsersPermissionGroups_permission_group_id', [...." (*OR should it be the other way around? :) :) )

The reason for adding the field name is illustrated below:

$this->belongsTo('Users_Users_inserted_id', [
'className' => 'Users',
'foreignKey' => 'inserted_id',
]);
$this->belongsTo('Users_Users_updated_id', [
'className' => 'Users',
'foreignKey' => 'updated_id',
]);
$this->belongsTo('Users_Users_designated_id', [
'className' => 'Users',
'foreignKey' => 'designated_id',
]);
$this->belongsTo('Users_Users_converted_id', [
'className' => 'Users',
'foreignKey' => 'converted_id',
]);

Well, if the idea is useful, I hope you can refine it and adapt it to cakePHP standards.

UsersTable.txt

Just look, I imagine something like this.
But the generated name may seem a bit 'strange'. Lack of creativity, I think. It became 'table.RelatedTable_link_field'.
For example, "$this->belongsTo('UsersPermissionGroups_permission_group_id', [...."
(*OR should it be the other way around? :) :) )

The reason for adding the field name is illustrated below:


  $this->belongsTo('Users_Users_inserted_id', [
    'className' => 'Users',
    'foreignKey' => 'inserted_id',
  ]);
  $this->belongsTo('Users_Users_updated_id', [
    'className' => 'Users',
    'foreignKey' => 'updated_id',
  ]); 
  $this->belongsTo('Users_Users_designated_id', [
    'className' => 'Users',
    'foreignKey' => 'designated_id',
  ]);
  $this->belongsTo('Users_Users_converted_id', [
    'className' => 'Users',
    'foreignKey' => 'converted_id',
  ]);

Well, if the idea is useful, I hope you can refine it and adapt it to cakePHP standards.
@dereuromark
Copy link
Member

The class name must stay a valid one imo
And aliases need to keep the convention
Better to properly continue what I started

@luizcmarin
Copy link
Contributor Author

O nome da classe deve permanecer válido na minha opinião. E os aliases precisam manter a convenção. É melhor continuar corretamente o que comecei.

I don't have the experience to continue following your work. Could you guide, correct, suggest changes, specific links to the standard, etc.?

That way I could try to learn. Just saying that it's not correct doesn't help me progress. And I would like to progress and learn more.

@dereuromark
Copy link
Member

Yes, let me try to finish up my PR these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants