-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @phpcsSuppress to Command::execute
#950
Conversation
20f6849
to
9bba47f
Compare
Is there no way to fix the actual phpcs rule to not throw wrong error? |
I would recommend opening a Bug ticket or pr for their repo |
We can just bake with |
This pull request is stale because it has been open 30 days with no activity. Remove the |
Re-opened so we can follow up with the recomendation. |
This pull request is stale because it has been open 30 days with no activity. Remove the |
That PHPCS is most likely fixed, this was a tooling issue on the CS ruleset. |
PHPCS will complain about missing return-type hints when you bake your first command.
PHPCBF then adds
: int|null|null
🤔