3.x: adjust annotations #954
Conversation
LordSimal
force-pushed
the
3.x-new-annotations
branch
2 times, most recently
from
564dab6 to
283856a
Compare
LordSimal
force-pushed
the
3.x-new-annotations
branch
from
283856a to
d3cf7d6
Compare
LordSimal
force-pushed
the
3.x-new-annotations
branch
from
39012ad to
24e79f4
Compare
|
Had to ignore that stan issue because as you can see in https://github.com/cakephp/bake/actions/runs/6530648862/job/17730339754?pr=954#step:7:67 this will get generated with the lowest chronos version due to the fact, that it doesn't extend Datetime in that specific version |
| $annotations[] = "@method \Cake\Datasource\ResultSetInterface<\\{$namespace}\\Model\\Entity\\{$entity}>|false saveMany(iterable \$entities, array \$options = [])"; | ||
| $annotations[] = "@method \Cake\Datasource\ResultSetInterface<\\{$namespace}\\Model\\Entity\\{$entity}> saveManyOrFail(iterable \$entities, array \$options = [])"; | ||
| $annotations[] = "@method \Cake\Datasource\ResultSetInterface<\\{$namespace}\\Model\\Entity\\{$entity}>|false deleteMany(iterable \$entities, array \$options = [])"; | ||
| $annotations[] = "@method \Cake\Datasource\ResultSetInterface<\\{$namespace}\\Model\\Entity\\{$entity}> deleteManyOrFail(iterable \$entities, array \$options = [])"; |
There was a problem hiding this comment.
That doesn't look right to me. While those methods could return \Cake\Datasource\ResultSetInterface, they generally return what they were fed with in the $entities argument, which would be iterable<\Cake\Datasource\EntityInterface>.
I think the point of additionally having \Cake\Datasource\ResultSetInterface, was to account for the use-case of passing (modified) query results into these methods.
There was a problem hiding this comment.
Indeed, we could use iterable<\Cake\Datasource\EntityInterface>|\Cake\Datasource\ResultSetInterface here
closes #946