Fix annotation for entity field mapped to enum type. #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but will let @LordSimal confirm the type is built properly. |
|
LGTM 👍🏻 |
othercorey
reviewed
Nov 2, 2023
|
|
||
| default: | ||
| if (str_starts_with($type, 'enum-')) { | ||
| $dbType = TypeFactory::build($type); |
There was a problem hiding this comment.
@LordSimal Won't this throw an exception if the type isn't found? Is that ok for a catch-all?
There was a problem hiding this comment.
Indeed, we might wanna use try catch
There was a problem hiding this comment.
I am not really sure this situation is possible.
Getting to this case where the cake type string starts with enum- (basically) requires it being generated by
EnumType::from(MyEnum::class)
So that DBType needs to be present in the TypeFactory
|
For IdeHelper I did dereuromark/cakephp-ide-helper#333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958