Bake table with enums mapped. #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Dec 23, 2023
|
|
||
| namespace Bake\Test\App\Model\Table; | ||
|
|
||
| use Bake\Test\App\Model\Enum\BakeArticleStatus; |
There was a problem hiding this comment.
I like this convention. It helps ensure that enums are scoped to the entity so that we don't easily get conflicts.
ADmad
reviewed
Dec 23, 2023
dereuromark
force-pushed
the
3.x-bake-table-with-enum
branch
from
b6af28f to
141b704
Compare
dereuromark
commented
Dec 23, 2023
dereuromark
force-pushed
the
3.x-bake-table-with-enum
branch
3 times, most recently
from
ff9a32f to
85cdd3c
Compare
Makes detection more strict by requiring the looked up words to be positioned at the end of the field name, and possible leading characters to be a separator. refs #957
dereuromark
force-pushed
the
3.x-bake-table-with-enum
branch
from
85cdd3c to
386f5b7
Compare
|
Also, how can we cleanup the FQCN here inside the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #968
Currently finds the enums per fields, e.g.
This already works, but needs some cleanup
How do we avoid the fqcn for example? Use statements should be used instead.