Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Correct asserted view code #986

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[2.x] Correct asserted view code #986

merged 2 commits into from
Apr 26, 2024

Conversation

ravage84
Copy link
Member

@ravage84
Copy link
Member Author

Was the Table class behavior changed in regard to display fields or something?

In the test matrix, CI / testsuite (7.2, sqlite, prefer-lowest) (pull_request) installs CakePHP 4.3.0:

https://github.com/cakephp/bake/actions/runs/8847321556/job/24294924060?pr=986#step:9:17

But the other install 4.5.4:

https://github.com/cakephp/bake/actions/runs/8847321556/job/24294921670?pr=986#step:9:17

Either we bump the minimum requirement or we skip this test for any version where this behavior was different.

@markstory
Copy link
Member

Either we bump the minimum requirement or we skip this test for any version where this behavior was different.

Skipping the test when the cake version is going to generate different results seems ok to me. Bumping the required version for a test case seems silly.

@ravage84
Copy link
Member Author

Test skipped with clear message why.

@dereuromark dereuromark merged commit 7d7c919 into 2.x Apr 26, 2024
11 checks passed
@dereuromark dereuromark deleted the 2.x-assert-nick branch April 26, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants