refactor(css): use a footer style rather than negative margin hack

cal-itp · Dec 11, 2024 · 36b9a3b · 36b9a3b
1 parent d8554b0
commit 36b9a3b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/benefits/eligibility/forms.py b/benefits/eligibility/forms.py
@@ -109,7 +109,6 @@ def __init__(
         self.headline = headline
         self.blurb = blurb
 
-        self.classes = "mb-fix"
         sub_widget = widgets.FormControlTextInput(placeholder=sub_placeholder)
         if sub_pattern:
             sub_widget.attrs.update({"pattern": sub_pattern})

diff --git a/benefits/eligibility/templates/eligibility/confirm.html b/benefits/eligibility/templates/eligibility/confirm.html
@@ -1,5 +1,9 @@
 {% extends "core/base.html" %}
 
+{% block classes %}
+  {{ block.super | add:" eligibility-confirm" }}
+{% endblock classes %}
+
 {% block page-title %}
   {{ form.title }}
 {% endblock page-title %}

diff --git a/benefits/static/css/styles.css b/benefits/static/css/styles.css
@@ -88,10 +88,6 @@ li {
   list-style-type: disc;
 }
 
-.mb-fix {
-  margin-bottom: -40px;
-}
-
 /* Links */
 /* Same sizes for all screen widths: 18px */
 a:not(.btn):not(.card) {
@@ -301,6 +297,10 @@ footer {
   margin-top: 64px;
 }
 
+.eligibility-confirm footer {
+  margin-top: 24px;
+}
+
 footer .footer-links li a.footer-link {
   color: var(--footer-link-color);
   font-weight: var(--footer-link-font-weight);