Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make active flags False by default #1746

Closed
wants to merge 2 commits into from
Closed

Fix: make active flags False by default #1746

wants to merge 2 commits into from

Conversation

thekaveman
Copy link
Member

Closes #1742

Moves the hard-coded MST active flag into settings so it is like the others (even though we are live with them already!)

@thekaveman
chore: default active flags to False
fa5a9e7 
avoids race condition when environment is not yet updated
@thekaveman thekaveman requested a review from a team as a code owner September 21, 2023 22:29
@github-actions github-actions bot added migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev infrastructure Terraform, Azure, etc. back-end Django views, sessions, middleware, models, migrations etc. and removed migrations [auto] Review for potential model changes/needed data migrations updates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Sep 21, 2023
@thekaveman
chore: move MST active flag to settings
fa3e13a 
keep default of True since this agency is already live
@thekaveman thekaveman marked this pull request as draft September 21, 2023 22:46
@thekaveman thekaveman closed this Sep 21, 2023
@thekaveman thekaveman mentioned this pull request Sep 21, 2023
Closed
3 tasks
@thekaveman thekaveman deleted the fix/active-false branch February 28, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
back-end Django views, sessions, middleware, models, migrations etc. infrastructure Terraform, Azure, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the active flags FALSE by default
1 participant
@thekaveman