-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add SBTMD Mobility Pass configuration #1771
Conversation
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)benefits/eligibility/forms.py
benefits/settings.py
|
@angela-tran @thekaveman I have this running locally with the latest I'm not sure why. |
@machikoyasuda I'm also failing to verify with the new users, but I noticed this in the logs of my local
So it looks like maybe the eligibility type isn't getting there from Benefits? |
Confirmed locally |
Ready for re-review @thekaveman |
@machikoyasuda will review today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I was able to run locally and verify a sample user.
Couple of things post-merge:
- I note that some of the language (particularly on the form) is slightly different from the spreadsheet; I agree with the version in this PR, since it matches more closely to Courtesy Cards. Please work with @indexing to make sure the spreadsheet is accurate.
- If you haven't already, please update the Key Vault secrets for the public keys: rename
server-public-key
tomst-server-public-key
and addsbmtd-server-public-key
for all 3 environments. Use a placeholder like#
for SBMTD for now.
@@ -220,6 +232,23 @@ def load_data(app, *args, **kwargs): | |||
start_template="eligibility/start--senior.html", | |||
) | |||
|
|||
sbmtd_mobility_pass_verifier = EligibilityVerifier.objects.create( | |||
name=os.environ.get("MOBILITY_PASS_VERIFIER_NAME", "Eligibility Server Verifier"), | |||
active=os.environ.get("MOBILITY_PASS_VERIFIER_ACTIVE", "True").lower() == "true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just noticed something else.
We need an app config and key vault secrets for this active
setting as well.
And let's go ahead and make the default False
here so it doesn't turn on by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@machikoyasuda we'll need a follow-up PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, all the MOBILITY_PASS_*
environment variables need key vault secrets defined in Terraform. I'll create a new issue.
See #1777
closes #1664
Note: Will require a PR into Eligibility Server first (for sample data and server.pub keys) before the form will return success for a eligible user correctly.
Tasks
EligibilityType
for "SBMTD Mobility Pass"EligiblityVerifier
using MST CC as an exampleSERVER_PUBLIC_KEY_URL
variableSBMTDMobilityPass
with configuration (labels, helper, validation, etc.)TransitAgency
Acceptance criteria
SBMTD
tab of spreadsheetserver
) correctly verifies eligible and ineligible users