Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: block Sqlite scraper patterns #1781

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Chore: block Sqlite scraper patterns #1781

merged 1 commit into from
Nov 15, 2023

Conversation

thekaveman
Copy link
Member

See recent Sentry errors, e.g. https://sentry.calitp.org/organizations/sentry/issues/73065/?project=3

The database file cannot be served anyway, but this just rejects the request earlier in the chain to avoid hitting the application layer at all.

@thekaveman thekaveman added the security Changes to improve or maintain the availability and resilience of the app label Nov 9, 2023
@thekaveman thekaveman added this to the Admin tool: v1 milestone Nov 9, 2023
@thekaveman thekaveman requested a review from a team as a code owner November 9, 2023 22:17
@thekaveman thekaveman self-assigned this Nov 9, 2023
@github-actions github-actions bot added the docker Application container, devcontainer, Compose, etc. label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@machikoyasuda machikoyasuda self-requested a review November 15, 2023 22:13
@thekaveman thekaveman merged commit 10da104 into dev Nov 15, 2023
9 checks passed
@thekaveman thekaveman deleted the chore/db-scrapers branch November 15, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Application container, devcontainer, Compose, etc. security Changes to improve or maintain the availability and resilience of the app
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants