-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump django from 4.2.7 to 5.0 #1809
Conversation
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
5b1af76
to
adeefac
Compare
adeefac
to
56d7eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through all these checks: #1417 (review)
@angela-tran When you have a chance, do you mind testing this one locally too - just to be safe? |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
71ff047
to
3a5b35c
Compare
@dependabot rebase |
3a5b35c
to
acab922
Compare
acab922
to
71ff047
Compare
| [**Agency cards**](/benefits/enrollment-pathways/agency-cards) | [Eligibility API](https://docs.calitp.org/eligibility-api/specification/) | Live | [11/2022](https://github.com/cal-itp/benefits/releases/tag/2022.11.1) | | ||
| [**Veterans**](/benefits/enrollment-pathways/veterans) | [Veteran Confirmation API](https://developer.va.gov/explore/api/veteran-confirmation) | Live | [09/2023](https://github.com/cal-itp/benefits/releases/tag/2023.09.1) | | ||
| [**Veterans**](/benefits/enrollment-pathways/veterans) | [Veteran Confirmation API](https://developer.va.gov/explore/api/veteran-confirmation) | Live | [09/2023](https://github.com/cal-itp/benefits/releases/tag/2023.09.1) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just spacing changes from the linters.
Bumps [django](https://github.com/django/django) from 4.2.7 to 5.0. - [Commits](django/django@4.2.7...5.0) --- updated-dependencies: - dependency-name: django dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
71ff047
to
13bcb1b
Compare
@machikoyasuda Local testing for me went fine ✅ Some things from reading over Django 5.0 release notes:
Removed it from our settings file in 0abbf67
Not sure if this is what they're talking about with "the app registry has been fully populated", but I'm seeing this in our logs now when starting up:
Not going to block this PR since we haven't had any problems due to this. Just noting why this warning is showing up now. |
Should we be worried about this / look into it further? What can go wrong if "the app registry has not been fully populated" / what does that even mean? |
Looking into this a little further, I found some Django docs that correspond with the Our The "Application intialization process" documentation describes how the app registry gets populated and why "premature database queries are discouraged": https://docs.djangoproject.com/en/5.0/ref/applications/#initialization-process But I'm not sure if there's a better place for us to register our Authlib configurations. Maybe we should register each |
🤔 This sounds intriguing.... |
Bumps django from 4.2.7 to 5.0.
Commits
617bcf6
[5.0.x] Bumped version for 5.0 release.94914b5
[5.0.x] Finalized release notes for Django 5.0.8e1b820
[5.0.x] Updated translations from Transifex.e4d7cc3
[5.0.x] Added release date for 4.2.8.cb013fc
[5.0.x] Fixed #35002 -- Made UniqueConstraints with fields respect nulls_dist...6c50273
[5.0.x] Fixed #35001 -- Fixed position of related widget action icons in admi...b8a476b
[5.0.x] Improved wording in auth.models.User field docs.471fa92
[5.0.x] Fixed #34995 -- Improved position of related widget's add link on adm...9fe12b0
[5.0.x] Refs #34995 -- Made Selenium tests more robust for admin_views and ad...7f1dc67
[5.0.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_co...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)