Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix NIST typo in English. #1827

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix: Fix NIST typo in English. #1827

merged 1 commit into from
Dec 14, 2023

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 14, 2023

closes #1747

What this PR does

  • Fixes NIST typo on the Help page and in the Login.gov modal for English.
  • The Spanish typo remains.

Note: This typo came straight from the Login.gov Developer documentation. The typo on the those docs have been corrected: GSA-TTS/identity-dev-docs#380

We still don't really know the official NIST name in Spanish.

Screenshots

image image

@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Dec 14, 2023
Copy link

Coverage report

The coverage rate went from 90.87% to 90.87% ➡️
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@machikoyasuda machikoyasuda self-assigned this Dec 14, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review December 14, 2023 21:39
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 14, 2023 21:39
@machikoyasuda machikoyasuda merged commit dbd3ed7 into dev Dec 14, 2023
12 checks passed
@machikoyasuda machikoyasuda deleted the fix/1747-nist-typo branch December 14, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor typo in Help / Login.gov modal
2 participants