Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update SBMTD agency card name in user-facing text #1953

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

thekaveman
Copy link
Member

Closes #1952

@thekaveman thekaveman requested a review from a team as a code owner March 13, 2024 22:42
@thekaveman thekaveman self-assigned this Mar 13, 2024
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework back-end Django views, sessions, middleware, models, migrations etc. and removed front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Mar 13, 2024
@thekaveman thekaveman added the i18n Copy: Language files or Django i18n framework label Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/eligibility
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

@thekaveman thekaveman requested a review from indexing March 13, 2024 22:55
angela-tran
angela-tran previously approved these changes Mar 14, 2024
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🙏

I noticed our documentation on manual tests says "Mobility Pass." It's not necessarily "user"-facing and is definitely not Benefits app copy, but just thought I'd mention it

@indexing
Copy link
Member

@thekaveman I reviewed each instance where the new name appears in Spanish and I didn't see any areas where the change "broke" the copy. @mrose914 and I will do a final review during copy "testing" as part of the low-income pathway.

Copy link

@thekaveman
Copy link
Member Author

thekaveman commented Mar 15, 2024

@indexing and I spoke about this yesterday -- we want to separate this effort fully from the Low-income pathway to ensure it can go out unencumbered by that work and in time for SBMTD's April 4th event.

@angela-tran good call about the docs -- while not explicitly user-facing, it is still public content and we don't want to introduce any confusion for anyone that might stumble across it, I have updated.

I propose that after Angela reviews (and hopefully approves) this PR, we get it released ASAP, maybe even a quick release today (I can handle that). I have bumped the application version in this PR in anticipation of a release.

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚌 💳

@thekaveman thekaveman enabled auto-merge March 15, 2024 17:07
@thekaveman thekaveman merged commit d3061e9 into dev Mar 15, 2024
13 checks passed
@thekaveman thekaveman deleted the chore/update-sbmtd-agency-card-name branch March 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBMTD: Update agency card name in user-facing text
3 participants