Feat: EligibilityType model fields for expiration #1955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
back-end
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
`supports_expiration` serves as a toggle for expiration functionality. the other fields are for configuring the duration before expiration and reenrollment.
this is to prepare for implementing custom validation
angela-tran
force-pushed
the
feat/expiration
branch
from
e3a2c13 to
e695317
Compare
angela-tran
force-pushed
the
feat/expiration
branch
from
e695317 to
fa36f7b
Compare
thekaveman
reviewed
Mar 14, 2024
| @@ -26,6 +27,33 @@ | |||
| admin.site.register(model) | |||
|
|
|||
|
|
|||
| class EligibilityTypeForm(forms.ModelForm): | |||
There was a problem hiding this comment.
I was hoping this could be done without a custom admin form?
I think implementing clean() in the model class should be enough?
There was a problem hiding this comment.
Oh I see now that it could be done that way too and that we don't need the custom admin form. I'll put this back in draft and move the logic to be done on the model
|
Superseded by #1957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1938
This PR adds fields to the
EligibilityTypemodel that will be needed to support expiration of benefits.Since these fields can be edited in the admin interface, this PR also configures what
formshould be used so that we can perform custom validation as specified on #1938.