Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: system enrollment error #2066

Closed
wants to merge 2 commits into from
Closed

Feat: system enrollment error #2066

wants to merge 2 commits into from

Conversation

angela-tran
Copy link
Member

Closes #2032

@angela-tran angela-tran self-assigned this Apr 30, 2024
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. labels Apr 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/enrollment
  views.py 61
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran force-pushed the chore/system-enrollment-error branch from cef38bd to b93f076 Compare May 1, 2024 23:15
@angela-tran
Copy link
Member Author

angela-tran commented May 13, 2024 •
edited
Loading

This PR was starting to cover too many things (Javascript redirect, page template, 500 error in index, 500 error in token, tests for all those things, etc.) so it will be superseded by smaller, more focused PRs, e.g. #2088.

@angela-tran
Copy link
Member Author

Closing this in favor of smaller PRs linked on #2032

@thekaveman
Copy link
Member

@angela-tran safe to delete the branch?

@angela-tran angela-tran deleted the chore/system-enrollment-error branch June 11, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@angela-tran angela-tran

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
Improved UX for application error states
Development

Successfully merging this pull request may close these issues.

New System enrollment error page
2 participants
@angela-tran @thekaveman