Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Enrollment View #2327

Closed
wants to merge 13 commits into from
Closed

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Aug 28, 2024

Closes #2244

WIP

image

@angela-tran angela-tran self-assigned this Aug 28, 2024
@github-actions github-actions bot added the front-end HTML/CSS/JavaScript and Django templates label Aug 28, 2024
@angela-tran angela-tran changed the title Feat: in-person enrollment view Admin: Enrollment View Aug 28, 2024
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits
  routes.py
  settings.py
  benefits/enrollment
  enrollment.py
  forms.py
  views.py
  benefits/in_person
  views.py 33-40, 90
Project Total  

This report was generated by python-coverage-comment-action

@angela-tran angela-tran force-pushed the feat/in-person-enrollment-view branch 9 times, most recently from 9e4a27b to 8a37a63 Compare September 3, 2024 22:35
@angela-tran angela-tran force-pushed the feat/in-person-enrollment-view branch 3 times, most recently from 1d62d10 to 66c859f Compare September 4, 2024 18:35
this is so it can be reused in `enrollment.index` and
`in_person.enrollment` when they receive a GET request.
this is needed temporarily while the eligibility view is still being
worked on.
the card tokenization flow listens for the `element`'s click event
before it will set the iframe `src`.

use a Promise to wait for the card tokenization function to finish and
then programmatically click the button which is not displayed to the
user.
this allows form submission to go through, but it is currently POST-ing
to the Benefits view functions; further refactoring will be done to
change that.
form submission now POSTs to the in_person `enrollment` view function,
which does not handle POSTs just yet.
reuse it in the `in_person.enrollment` view.

this gets us back to having a working form submission in the in-person
enrollment view, but we need to be able to configure which templates
to return for the various success / error scenarios.
@angela-tran
Copy link
Member Author

Closing in favor of split out PRs which do refactoring first (#2338 and #2339) and then implement the in-person enrollment view

@angela-tran angela-tran closed this Sep 6, 2024
@angela-tran angela-tran deleted the feat/in-person-enrollment-view branch September 6, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement enrollment view and template
2 participants