Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: reCAPTCHA copy + redesign #2572

Draft
wants to merge 65 commits into
base: main
Choose a base branch
from
Draft

Refactor: reCAPTCHA copy + redesign #2572

wants to merge 65 commits into from

Conversation

angela-tran
Copy link
Member

This PR will be merged in once all tickets on #2537 are done.

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  benefits/eligibility
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

machikoyasuda and others added 20 commits December 5, 2024 16:14
@machikoyasuda
feat(recaptcha): all H1s are now left-aligned on desktop and mobile
0ed1e18
@machikoyasuda
feat(recaptcha): convert elig page to all col-lg-6
a10e1ac
@machikoyasuda
feat(recaptcha): eligibility - remove 64px margin from all agency ind…
eb69d78 
…exes
@machikoyasuda
refactor(css): use class to position, instead of declaring styles
d844dec
@machikoyasuda
refactor(css): use gap-4 (24px), gap-md-3 (16px); bump up 15px to 16px
e945960
@machikoyasuda
refactor: remove unused css class
1342b24
@machikoyasuda
reCAPTCHA: Eligibility index page - Align page and refactor (#2570)
2ed9222
@machikoyasuda
feat(elig-start): recaptcha - first pass @ col-lg-6 for text and button
9f61a3e
@machikoyasuda
refactor: eliminate unnecessary div
bf2825a
@machikoyasuda
feat(elig-start): widen cta, narrow text for all eligibility start op…
4d0a733 
…tions
@machikoyasuda
feat(elig-start): widen cta, narrow text for agency card
207b849
@machikoyasuda
refactor: an attempt to refactor media-item css
64c3c31
@machikoyasuda
fix(css): create list-disc class instead
00f3f38
@machikoyasuda
refactor(media-item): delete unnecessary classes, divs in media-item
6e16a2e
@machikoyasuda
refactor(elig-start): remove unnecessary class, div from all id media…
b2b91f1 
…-items for each flow
@machikoyasuda
feat(css): first pass @ get started with login.gov button
f41cb98
@machikoyasuda
refactor(media-item): remove unused header-wrapper, media-body div/class
e27350b
@machikoyasuda
fix(css): update h2-sm-p comment
ed39e8c
@machikoyasuda
fix(enrollment-index-calfresh): add list-unstyled, remove media-item …
00cc296 
…class
@machikoyasuda
reCAPTCHA: Eligibility Start (#2573)
c90f30c
@machikoyasuda
Copy link
Member

machikoyasuda commented Dec 11, 2024 •
edited
Loading

As of today:
image

Oops didn't mean to close. Just comment.

@machikoyasuda machikoyasuda reopened this Dec 11, 2024
@machikoyasuda
chore(pre-commit): run autofix
d881a12
@machikoyasuda
chore(pre-commit): run autofix (#2589)
7a4e5fb
@machikoyasuda
feat(error-template): realign error template for 200 error, 400, 404,…
fa88233 
… 500 error pages
@machikoyasuda
feat(oauth-error): realign oauth system error page
e55fd29
@machikoyasuda
feat(reenrollment-calfresh): realign template for reenrollment error …
01112e9 
…calfresh
@machikoyasuda
fix: remove unnecessary outer div, provided by base
9a9c646
@machikoyasuda
feat(enrollment-error): realign template, update css for enrollment s…
8a301c6 
…ys error pg
@machikoyasuda
feat(enrollment-retry): realign template for reenrollment retry error
2acaf46
@machikoyasuda
feat(elig-unverified): realign eligibility unverified error page
732f794
@machikoyasuda
refactor(templates): move log out button into nav-buttons
f2f7358
@machikoyasuda
refactor(error): all error pages now extend error
a85e8d9
@machikoyasuda
refactor: rename error to error-base, for consistency
4e6eeab
@machikoyasuda
test(models): update test_tempate_path spec
5b91916
@machikoyasuda
refactor(oauth-error): remove unnecessary button call, inherited from…
9ed5091 
… error-base
@machikoyasuda
refactor(error-base): loading i18n not necessary
46fd496
@machikoyasuda
refactor(error-base): remove redundant title call and use page-title …
2a69f17 
…from base
@machikoyasuda
refactor(error-base): set sad bus icon as the default icon
812446c
@machikoyasuda
feat(help): realign Help page width, combine some divs
cb558f4
@machikoyasuda
fix: remove unnecessary class
54fb16f
@machikoyasuda
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
Benefits app frontend enhancements an...
Development

Successfully merging this pull request may close these issues.
3 participants
@angela-tran @machikoyasuda @thekaveman