Fix/Refactor: Eligibility Start #2583
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| @@ -13,13 +13,13 @@ | |||
| {% block inner-content %} | |||
| <div class="col-lg-6"> | |||
| <p class="py-4">{% translate "You will need a few items to continue:" %}</p> | |||
| <ul class="d-flex flex-column gap-4 list-unstyled ps-0 pb-5 mb-3"> | |||
| <ul class="d-flex flex-column gap-4 list-unstyled ps-0 mb-0"> | |||
There was a problem hiding this comment.
Got it, removing all this bottom padding because of how we have pt-8 from the <div> that surrounds the call-to-action-button block 👍
| @@ -6,19 +6,15 @@ | |||
| {% endblock page-title %} | |||
|
|
|||
| {% block headline %} | |||
| <div class="col-lg-8"> | |||
| <div class="col-lg-6"> | |||
There was a problem hiding this comment.
We probably could do something on the start.html template so that we don't have to repeat
<div class="col-lg-6">
<h1>
...
</h1>
</div>
on every one of these templates.
Something like
{% block headline %}
<div class="col-lg-6">
<h1>
{% block headline-text %}
{% endblock headline-text %}
</h1>
</div>
{% endblock headline %}
and then the start--<agency>--<flow>.html templates just override the headline-text block.
I had the thought so wrote it down, but I don't feel strongly about doing it or not. It's really not that much duplicate code, but then again we did have to remember to update the 8 to 6 in multiple places. 🤷♀️
There was a problem hiding this comment.
I am thinking about doing this for all templates in base.html in #2540, but I like the idea of starting that effort here for all the start-agency-flow templates!
There was a problem hiding this comment.
Done! cf11c04 Really like how the start-agency-flow templates are looking now, very clean and stream-lined.
There was a problem hiding this comment.
Ditto! I think this is inching us further towards copy that is easier to manage as well!
| @@ -6,19 +6,15 @@ | |||
| {% endblock page-title %} | |||
|
|
|||
| {% block headline %} | |||
| <div class="col-lg-8"> | |||
| <div class="col-lg-6"> | |||
After grepping through the codebase for
col-lg-8, I realized I had missed 2 Eligibility Start template includes in #2573: MST Courtesy Card and SBMTD were still oncol-lg-8, not6.While fixing these templates up, and getting tired of repeating the same old code to center the button (
<div class="row justify-content-center"> <div class="col-12 col-lg-6">...), I realized that the main Eligibility Start template could instead inheritcall-to-action-button, and use the button centering code frombase.htmlinstead. So I cleaned that up here.Now, if the button style for Eligibility Start changes somehow, we only have to change it in one file (
eligibility/start.html), not all the different flow templates.Lastly, I renamed
media-itemtoeligibility-item. Now the app is truly 1000% free ofmedia-itemHTML, CSS and filenames.