Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA: Help page #2584

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 10, 2024

closes #2545 (Part 1) / Error pages to come in separate PR

What this PR does

  • Changes text alignment to col-lg-8
  • Changes button alignment
  • Squashes some of the divs into 1 div

@machikoyasuda machikoyasuda self-assigned this Dec 10, 2024
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 10, 2024 21:50
<div class="row pt-4 pt-lg-8">
<div class="col-lg-2 offset-lg-10 col-8 offset-2">
<div class="row justify-content-center pt-4 pt-lg-8">
<div class="col-12 col-lg-6">
{% translate "Go Back" as button_text %}
{% include "core/includes/button--origin.html" with button_text=button_text %}
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using the call-to-action or call-to-action-button blocks instead, but I can't b/c I'm overriding the parent main-content block entirely. I'm okay with it though, b/c this page is a different alignment and design from the rest of the pages... so it feels appropriate to override the base layout.

@github-actions github-actions bot added the front-end HTML/CSS/JavaScript and Django templates label Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/eligibility
  forms.py
Project Total  

This report was generated by python-coverage-comment-action

@machikoyasuda machikoyasuda force-pushed the feat/2545-recaptcha-help branch from c98b867 to 54fb16f Compare December 12, 2024 19:19
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the divitis cleanup! (And for sharing that fantastic term 😁)

Just noting that this is now the only page where the heading is center aligned, which is fine.

@machikoyasuda machikoyasuda merged commit 2a7d08f into refactor/recaptcha-copy Dec 16, 2024
8 checks passed
@machikoyasuda machikoyasuda deleted the feat/2545-recaptcha-help branch December 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants