Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix agency link regression #2599

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 19, 2024

closes #2590

How did this bug happen

A regression was introduced in #2526. When I removed the CA State Web Template, it removed this piece of CSS:

image

Since the agency name area uses a <label> element, the element was getting font-weight: 700 from there. Now that the state web template is no longer being used, the element lost its bold font.

What this PR does

  • Changed the label to a regular p. (Using <label> for something that is not a form is not semantic.)
  • Created a .h4 CSS class, with the same exact attributes of the h4 element. And used the h4 class on this agency name, to get the h4 styles.
  • Added mt-1 to get the lines to be 4px away from each other.

QA

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Dec 19, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda self-assigned this Dec 19, 2024
@machikoyasuda machikoyasuda marked this pull request as ready for review December 19, 2024 00:39
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 19, 2024 00:39
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@machikoyasuda machikoyasuda merged commit 42ef555 into main Dec 19, 2024
9 checks passed
@machikoyasuda machikoyasuda deleted the fix/2590-agency-label-regression branch December 19, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Regression - Transit name is not bolded in agency links
2 participants