Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to prod #361

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Deploy to prod #361

merged 8 commits into from
Oct 31, 2023

Conversation

angela-tran
Copy link
Member

This is to get #359 into prod

@angela-tran angela-tran added this to the SBMTD Mobility Pass milestone Oct 31, 2023
@angela-tran angela-tran self-assigned this Oct 31, 2023
@angela-tran angela-tran requested a review from a team as a code owner October 31, 2023 17:54
@thekaveman
Copy link
Member

I think I am understanding what was meant in the Azure docs we keep going back and forth on from #294 (comment)

I am seeing for this PR, in MST, the plan was run (with expected results).

But in SBMTD, the pipeline only runs when the PR is merged. E.g. for #360 we got a successful run -- we're not getting the PR plan run here though.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to merge this.

But it seems like we will need to look into #294 to at least get the plan running in each pipeline when PRs are opened.

@angela-tran angela-tran merged commit df1cbec into prod Oct 31, 2023
9 checks passed
@thekaveman thekaveman deleted the test branch January 29, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants