Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fixes check for reusing old password in reset password #92

Merged

Conversation

varortz
Copy link
Collaborator

@varortz varortz commented May 24, 2024

🎋 Description

Fixes a bug where the user was not given feedback upon attempting to reuse their previous password in the reset password flow.

🌴 What's new in this PR

  • renames verifyUserPassword helper to verifyNewPassword
  • adds an await when calling verifyNewPassword to ensure we provide appropriate feedback when the user attempts to reuse their previous password.
    //: # "REQUIRED - Describe what's new in this PR in a few lines. A description and bullet points for specifics will suffice."

🌲 Screenshots

image

🌳 How to review

Attempt to reset the password of an already registered user:

  • Before testing update line 26 of forgot-password/index.tsx to 'http://localhost:3000/reset-password' and save
  • Navigate to the login page on localhost and click on the "Forgot your password?" link
  • Enter the email address of an already registered account. You should receive an email with a link to reset your password.
  • Enter the current/previous password. You should see the error message pictured in the screenshot above.

🌱 Next steps

🔗 Relevant Links

ℹ️ Online sources

🪴 Related PRs

CC: @varortz @kyrenetam

Copy link

linear bot commented May 24, 2024

@varortz varortz merged commit 54af926 into main May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant