-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] qr code scanner bug fixes #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes so far. I'm considering a few edge cases that we haven't decided how to handle yet.
When a user scans a valid barcode, the view case option will pop up and the border will turn green. However, if a different barcode is scanned right after, the screen should update:
- If the other barcode is valid, it'd be nice to somehow indicate that a different case was now scanned.
- If the other barcode is invalid, the view case option should disappear while the error toast message pops up. Maybe the border should turn red as well.
It also might be nice to move toast messages to the top of the screen so they don't overlap with the view case button.
Also..... BarCodeScanner is lowkey being deprecated: https://docs.expo.dev/versions/latest/sdk/bar-code-scanner/#component |
Josh Notes:
|
…to stephanie/qr-code-scanner-bugs
… improve usability.
…ide view case option after navigating to a different screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically rewrote the qr code query logic so it might look like a lot. Can you double check that the qr code works for different scanning scenarios?
What's new in this PR
Description
QR Code:
Case Screen:
CaseCard
.AllCases
to span entire screen.Screenshots
How to review
AllCases
screen looks proper with a varying number of cases. Might need to account for bottom tab in setting height.Relevant Links
Online sources
Expo Camera Documentation
Debouncing Functions
Lodash Library for Debouncing
CC: @ronniebeggs