[iOS] Use install_modules_dependencies in .podspec file #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In RN 0.70, the core team introduced the
install_modules_dependencies
function to properly configure the iOS dependencies in the podspec.This allow the Core team to add/remove flags and restructure the internal Cocoapods' structure of React Native and limiting the chances to break 3rd parties dependencies, as those changes will be captured by the function.
By not using this function, all the 3rd party libraries would have to chase and manually reimplement the same changes that the RN Core team applies to the Cocoapods structure.
Test Plan
Build and observe the failure.
Apply this patch to the
NewApp/node_modules/react-native-pager-view/react-native-pager-view.podspec
file and rerunBuild and observe the app build successfully:
What's required for testing (prerequisites)?
Nothing
What are the steps to reproduce (after prerequisites)?
See test plan
Compatibility
Checklist
The below items are not needed:
README.md