feat: added sensitivity controller to android #802
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request allows users to toggle the sensitivity on android. It is particularly useful for pagerview's that contain scrollable webviews.
Test Plan
Make sure the prop filters through the JS to reduceDragSensitivity kotlin function and is set correctly. Make sure the app visibly scrolls with less sensitivity as the number increasers.
What's required for testing (prerequisites)?
Just be able to run the app in android studio
What are the steps to reproduce (after prerequisites)?
Go to BasicPagerViewExample and add the prop
ScrollSensitivity={8}
in Android studio put a stop on
android/src/main/java/com/reactnativepagerview/PagerViewViewManagerImpl.kt on line 25.
Run the basic example and when the stop fires check that the prop is correctly set at 8.
You can also toggle the number and notice the reduced sensitivity on higher numbers.
Compatibility
Checklist
README.md