fix(android): index out of bounds crash #805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are using "react-native-tab-view" in Dream11 App. We were not able to reproduce the crash, But we are seeing crash instance in firebase. We can see that partial fix of this is already merged in react-native-tab-view. This fix works only if removeChildAt of ViewPagerAdapter gets called from removeChild of ViewPagerAdapter. The existing fix won't work here. This PR takes care of boundary conditions of childrenViews array.
Here are the attached logs/stack traces.
Compatibility
Checklist
README.md