-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate example to react-native-test-app
#834
Conversation
@szymonrybczak could you rebase your PR? 🙏 |
2845f39
to
67f36f1
Compare
d2c4979
to
800c006
Compare
react-native-test-app
react-native-test-app
83db2d2
to
40ecedb
Compare
CI is failing for iOS E2E tests because app built inside Release mode cannot grab
cc: @tido64 any ideas? Is there maybe anything that I'm missing in the config for app to run properly? |
When is |
@szymonrybczak Do you have repro steps? Seems to work for me. This is what I ran: yarn
cd example
yarn
yarn build:ios
pod install --project-directory=ios
yarn ios --no-packager --simulator 'iPhone 15 Pro' |
"ios": "react-native run-ios --list-devices", | ||
"android": "react-native run-android --appId com.pagerviewexample", | ||
"build:android": "npm run mkdist && react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res", | ||
"build:ios": "npm run mkdist && react-native bundle --entry-file index.js --platform ios --dev false --bundle-output dist/main.ios.jsbundle --assets-dest dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to add --dev false
in .github/workflows/ios.yml
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this script will be only used for building on CI, since for development yarn ios
already fires up packager.
f643a89
to
27992ea
Compare
27992ea
to
d4458a1
Compare
Summary
In this Pull Request I've migrated Example project to
react-native-test-app
.Test Plan
App should properly run and build on all platforms that
react-native-pager-view
supports.Compatibility
Checklist
README.md