fix(#722): revert not working back navigation gesture in favour of PagerView inside ScrollView #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateWW
force-pushed
the
fix/#722/scroll-view-issue
branch
from
41a7e80 to
3e5ea73
Compare
MateWW
changed the title
MateWW
changed the title
|
This PR will be merged once we close this one: #918 |
MrRefactor
reviewed
Nov 22, 2024
|
|
||
| <View> | ||
| <TabView | ||
| // TODO: Fix the height measurement for nested pager view |
There was a problem hiding this comment.
Please remove that TODO
MrRefactor
approved these changes
Nov 22, 2024
|
@MateWW Could you check this PR https://github.com/callstack/react-native-pager-view/pull/771/files if this is the same thing? |
yup, just in my case we have additional example in app to test that scenario |
MateWW
force-pushed
the
fix/#722/scroll-view-issue
branch
from
3e5ea73 to
18aed2e
Compare
…gerView inside ScrollView
MateWW
force-pushed
the
fix/#722/scroll-view-issue
branch
from
18aed2e to
0cf7d6f
Compare
Thank you 🙏 we will check that change once we test other PRs, which are already in a queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #722!
Issue
Currently scroll over legacy pager view is not working while nested inside scroll view.
Nesting might be necessary while we have big header which you don't want to be visible while you are swiping pages.
Root cause
The issue arise with 6.2.0 version and support for navigate back gesture.
Solution
I've tested that navigate back gesture and it didn't worked for me as you may see on attached video.
I've also checked if basic react native ScrollView supports that for horizontal mode and it's not.
Based on all above I believe it's not worth to block users and I reverted that change.
I think we can revisit that use case later and fix that long living regression.
Test Plan
2-pager-view-bug-fabric-ios.mp4
2-pager-view-fix-fabric-ios.mp4
2-pager-view-bug-paper-ios.mp4
2-pager-view-fix-paper-ios.mp4
Compatibility
Checklist