Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paper): prevent freeze on layout update during transition #941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krozniata
Copy link
Member

@krozniata krozniata commented Dec 2, 2024

Summary

This PR fixes issue causing component to freeze when layout was updated during transition - old arch

When layout was updated e.g. because of hiding keyboard, setViewControllers completion block was never called, which resulted in swipe being disabled

It fixes this issue by adding custom shadow view and preventing layout update during transition phase

Fixes #922

Test Plan

  1. Build the example app.
  2. Go to the Keyboard Example menu.
  3. Touch the TextInput to show the keyboard.
  4. Press the Next page button. (might be required to modify ControlPanel to move button above keyboard)
  5. Should navigate correctly, should be able to interact

Other examples should work as before

Compatibility

OS Implemented
iOS
Android

@krozniata krozniata requested review from okwasniewski, MrRefactor and troZee and removed request for okwasniewski and MrRefactor December 2, 2024 15:31
@MrRefactor
Copy link
Collaborator

Fixes #922

ios/RNCPagerViewShadowView.m Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(iOS) setPage calls with container layout changes cause the content to freeze
4 participants