Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #64 execution plan review #113

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Dec 12, 2024

This is just a PoC - not to be merged in. It shows how to replace a default supervisor with a custom one.

@grabbou I think I discovered an inconsistency/bug (?) - the supervisor is not able to run the tools. In this case, running the tools would make a lot of sense for getting the exec plan acceptance.

… + dividing it to more self-explanatory agent roles for making resourcePlanner life easier
… a custom one - planing the execution plan ahead
@pkarw pkarw requested a review from grabbou December 12, 2024 17:56
@grabbou
Copy link
Collaborator

grabbou commented Dec 13, 2024

What should we do with this PR? Aside from fixing the issue that you mentioned? Shall we do anything with that static supervisor? 👯‍♀️

@pkarw
Copy link
Collaborator Author

pkarw commented Dec 13, 2024

I'll test it on Monday and if it works fine I'd suggest adding this new supervisor as an example wdyt?

@grabbou
Copy link
Collaborator

grabbou commented Dec 13, 2024

Yeah why not! We can have a few, and actually, maybe I'll add parallel one as example too for now - to treat it as experimental?

@pkarw
Copy link
Collaborator Author

pkarw commented Dec 13, 2024

Great idea 🙌

@pkarw
Copy link
Collaborator Author

pkarw commented Dec 13, 2024

I can even imagine a distributed one - so there are few servers and resourcePlanner is using a tool to send a http request with a task for another instance to process. This is entirely possible due to our server architecture

Wdyt?

@grabbou grabbou marked this pull request as draft December 13, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants