V0.2.0 M4 #95

FabrizioMoggio · 2024-08-21T13:39:27Z

M4 version for Fall24:

OAS file renamed according to: Convention for file names of API definition #93
Remove “-rc.n” from the version and server path: Fall24 - M4 - Planning #92
Remove "-rc.02" from "x-camara-commonalities": Commonalitis Release for M4 #94
updated changelog.md
updated readme.md
updated .feature files according to: version in .feature files #96
updated Readiness CL according to: version in API readiness CL #97
updated changelog.md according to: Changelog #98
updated readme.md according to: Meetings information in README file #100

What type of PR is this?

Add one of the following kinds:

cleanup
documentation

What this PR does / why we need it:

final release for Fall24

Which issue(s) this PR fixes:

#94
#93
#96
#97
#98
#100

r1.3 added

for r1.3

according to: camaraproject#93

Remove “-rc.n” from the version and server path: camaraproject#92 Remove "-rc.02" from "x-camara-commonalities": camaraproject#94

Missing "Bold" termination characters (**)

hdamker · 2024-08-21T14:28:23Z

@FabrizioMoggio thanks for the release PR - have created camaraproject/ReleaseManagement#77 for the Release Management review.

Please update also the API Readiness checklist and the version within the .feature files as part of the PR.

hdamker · 2024-08-21T14:39:31Z

@FabrizioMoggio and another important point:

The Release Notes for a public release must be in generell a summary of all changes since the last public release, not just the delta to the last release candidate.
In your case - as there was no previous public release and everything is new - it's more a list of "What's new" as you had in the first release candidate - you don't need to mention the corrections of this new stuff which happened between the release candidates, as for someone who is taking this public release, everything is anyway new.

Note: the "full changelog" link is
Full Changelog: https://github.com/camaraproject/CallForwardingSignal/commits/r1.3

bigludo7

LGTM
Your PR will be used as an example for me for other API Fabrizio :)

bigludo7 · 2024-08-21T15:46:16Z

Correction for my comment: this @FabrizioMoggio PR will be the example once the comment from @hdamker will be fixed ;)

hdamker

Please update also the API Readiness checklist and the version within the .feature files as part of the PR
Complete the CHANGELOG for the public release with all updates, see my previous comment

hdamker · 2024-08-23T17:21:13Z

BTW: release tracker updated ... r1.3 will be the public release tag, not the next pre-release.

version v0.2.0 according to: camaraproject#95 (comment)

according to: camaraproject#96

according to: camaraproject#97

according to: camaraproject#98

FabrizioMoggio · 2024-08-30T21:12:24Z

I’m sorry to ask for advice, I’m trying do to my best 😊 from my holidays. For M4 I should have addressed all your comments. The current PR for the CFS API is targeting the public release. What I’m not sure of is if at 30/08 the public release should be merged (if so, we missed it 😊) or if the final approval from @camaraproject/release-management_maintainers is due for M5 (09-15).

hdamker · 2024-08-31T05:58:12Z

@FabrizioMoggio thank for taking car during your vacation! No worries, you have done every necessary for the M4 milestone by creating and updating this release PR so far. Indeed, the review and approval by Release Management will happen before M5 and then the merge.

@bigludo7 @chinaunicomyangfan Please review the PR and the latest changes as well and approve the PR already.

bigludo7

LGTM

FabrizioMoggio

the requested changes by @hdamker have been implemented

FabrizioMoggio · 2024-09-04T09:56:43Z

Please update also the API Readiness checklist and the version within the .feature files as part of the PR

Complete the CHANGELOG for the public release with all updates, see my previous comment

Dear @hdamker I don't know how to move forward. You requested a change and I have implemented it but I can't find a way to mark the requested changes as implemented. So I can't merge. Is it you that need to control and mark them as implemented?

including: the changes from: camaraproject#99 implementing issue: camaraproject#100

linux-foundation-easycla · 2024-09-04T10:18:16Z

❌ - login: @FabrizioMoggio . The commit (b78344d, f7586bd, 89e2c82, ce1826a, 92a5b23, 99013fa, 1a43a21, c944f0d, 5f10fc5, 13ebd54, 6db752a, 558c2bf) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

bigludo7

LGTM

The merge-base changed after approval.

tanjadegroot

a few broken links and typos to fix and this is OK: LGTM from release mgmt

tanjadegroot · 2024-09-04T16:58:19Z

CHANGELOG.md

+This is the first official release of the Call Forwarding Signal API, version 0.2.0. It contains mainly alignments with the Commonalities 0.4.0 and the Release Management Guidelines. 
+
+- API definition **with inline documentation**:
+  - OpenAPI [YAML spec file](https://github.com/camaraproject/CallForwardingSignal/blob/r1.3/code/API_definitions/Call_Forwarding_Signal.yaml)


All 3 links for API display in this section need to be updated to point to the new file name f the API yaml

tanjadegroot · 2024-09-04T17:08:46Z

README.md

Line 19 (location: virtually) can be removed from teh scope section.

tanjadegroot · 2024-09-04T17:10:22Z

README.md

-  - OpenAPI [YAML spec file](https://github.com/camaraproject/CallForwardingSignal/blob/r1.2/code/API_definitions/Call_Forwarding_Signal.yaml)
-  - [View it on ReDoc](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/CallForwardingSignal/r1.2/code/API_definitions/Call_Forwarding_Signal.yaml&nocors)
-  - [View it on Swagger Editor](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/CallForwardingSignal/r1.2/code/API_definitions/Call_Forwarding_Signal.yaml)
+  - OpenAPI [YAML spec file](https://github.com/camaraproject/CallForwardingSignal/blob/r1.3/code/API_definitions/Call_Forwarding_Signal.yaml)


All 3 links here need to be updated with the new API file name

tanjadegroot · 2024-09-04T17:31:05Z

code/API_definitions/call-forwarding-signal.yaml

Just 2 clarification questions

on line 229: does unconditional forwarding overwrite conditional forwarding if both are active ?

on line 230: with "This endpoit exceeds the main scope of the CFS API, for this reason an error code 501 can be returned" do you mean that this second endpoint is optional and may not be provided and that 501 is returned in that case ?

there is a type in "endpoint" in line 229

tanjadegroot · 2024-09-04T17:48:24Z

code/Test_definitions/call-forwarding-signal-unconditional.feature

Line 132: typo: involked -> invoked
Line 173: typo requst -> request

tanjadegroot · 2024-09-04T18:06:12Z

documentation/API_documentation/call-forwarding-signal-API-Readiness-Checklistst.md

@@ -1,21 +1,21 @@

 # API Readiness Checklist

-Checklist for API call-forwarding-signal v0.2.0-rc.2 in r1.2
+Checklist for API call-forwarding-signal v0.2.0 in r1.3


 | Nr | API release assets  | alpha | release-candidate |  public-release<br>initial | public-release<br> stable | Status | Comments |
 |----|----------------------------------------------|:-----:|:-----------------:|:-------:|:------:|:----:|:----|
 |  1 | API definition                               |   M   |         M         |    M    |    M   |   Y  | /code/API_definitions/Call_Forwarding_Signal.yaml |


change to new API yaml file name (call-forwarding-signal.yaml)

FabrizioMoggio · 2024-09-05T10:40:53Z

Closed because EasyCLA problems.

Replaced by: #101

FabrizioMoggio added 5 commits August 21, 2024 10:42

Update CHANGELOG.md

ce1826a

r1.3 added

Update README.md

b78344d

for r1.3

Rename Call_Forwarding_Signal.yaml to call-forwarding-signal.yaml

f7586bd

according to: camaraproject#93

v0.2.0

6db752a

Remove “-rc.n” from the version and server path: camaraproject#92 Remove "-rc.02" from "x-camara-commonalities": camaraproject#94

Update README.md

558c2bf

Missing "Bold" termination characters (**)

FabrizioMoggio requested review from bigludo7 and chinaunicomyangfan as code owners August 21, 2024 13:39

FabrizioMoggio requested review from jlurien, hdamker, tanjadegroot, rartych and soadeyemo August 21, 2024 13:41

FabrizioMoggio added documentation Improvements or additions to documentation Fall24 labels Aug 21, 2024

hdamker requested review from a team and removed request for hdamker, tanjadegroot, rartych and soadeyemo August 21, 2024 14:15

hdamker mentioned this pull request Aug 21, 2024

CallForwardingSignal r1.3 release review (M4) camaraproject/ReleaseManagement#77

Closed

11 tasks

bigludo7 previously approved these changes Aug 21, 2024

View reviewed changes

bigludo7 self-requested a review August 21, 2024 15:45

hdamker requested changes Aug 23, 2024

View reviewed changes

hdamker requested a review from a team August 27, 2024 15:38

Update call-forwarding-signal-every-forwarding.feature

92a5b23

version v0.2.0 according to: camaraproject#95 (comment)

FabrizioMoggio dismissed bigludo7’s stale review via 92a5b23 August 27, 2024 20:22

FabrizioMoggio mentioned this pull request Aug 27, 2024

version in .feature files #96

Closed

Update call-forwarding-signal-unconditional.feature

13ebd54

according to: camaraproject#96

This was referenced Aug 27, 2024

Convention for file names of API definition #93

Closed

version in API readiness CL #97

Closed

Update call-forwarding-signal-API-Readiness-Checklistst.md

5f10fc5

according to: camaraproject#97

FabrizioMoggio mentioned this pull request Aug 27, 2024

Changelog #98

Closed

Update CHANGELOG.md

89e2c82

according to: camaraproject#98

bigludo7 previously approved these changes Sep 2, 2024

View reviewed changes

FabrizioMoggio commented Sep 4, 2024

View reviewed changes

Meetings information on README.MD

c944f0d

including: the changes from: camaraproject#99 implementing issue: camaraproject#100

FabrizioMoggio dismissed bigludo7’s stale review via c944f0d September 4, 2024 10:18

Update README.md typo

99013fa

bigludo7 previously approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'main' into v0.2.0_M4

1a43a21

tanjadegroot suggested changes Sep 4, 2024

View reviewed changes

hdamker mentioned this pull request Sep 4, 2024

Public Release for Fall24 meta-release #101

Merged

FabrizioMoggio closed this Sep 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V0.2.0 M4 #95

V0.2.0 M4 #95

FabrizioMoggio commented Aug 21, 2024 •

edited

Loading

hdamker commented Aug 21, 2024

hdamker commented Aug 21, 2024

bigludo7 left a comment

bigludo7 commented Aug 21, 2024

hdamker left a comment

hdamker commented Aug 23, 2024

FabrizioMoggio commented Aug 30, 2024

hdamker commented Aug 31, 2024

bigludo7 left a comment

FabrizioMoggio left a comment

FabrizioMoggio commented Sep 4, 2024

linux-foundation-easycla bot commented Sep 4, 2024 •

edited

Loading

bigludo7 left a comment

tanjadegroot left a comment

tanjadegroot Sep 4, 2024

tanjadegroot Sep 4, 2024

tanjadegroot Sep 4, 2024

tanjadegroot Sep 4, 2024

tanjadegroot Sep 4, 2024

tanjadegroot Sep 4, 2024

FabrizioMoggio commented Sep 5, 2024

V0.2.0 M4 #95

V0.2.0 M4 #95

Conversation

FabrizioMoggio commented Aug 21, 2024 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

hdamker commented Aug 21, 2024

hdamker commented Aug 21, 2024

bigludo7 left a comment

Choose a reason for hiding this comment

bigludo7 commented Aug 21, 2024

hdamker left a comment

Choose a reason for hiding this comment

hdamker commented Aug 23, 2024

FabrizioMoggio commented Aug 30, 2024

hdamker commented Aug 31, 2024

bigludo7 left a comment

Choose a reason for hiding this comment

FabrizioMoggio left a comment

Choose a reason for hiding this comment

FabrizioMoggio commented Sep 4, 2024

linux-foundation-easycla bot commented Sep 4, 2024 • edited Loading

bigludo7 left a comment

Choose a reason for hiding this comment

tanjadegroot left a comment

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

tanjadegroot Sep 4, 2024

Choose a reason for hiding this comment

FabrizioMoggio commented Sep 5, 2024

FabrizioMoggio commented Aug 21, 2024 •

edited

Loading

linux-foundation-easycla bot commented Sep 4, 2024 •

edited

Loading