Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pygeodesics #375

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jo-mueller
Copy link
Member

Description

This PR replaces the pygeodesics dependency with the potpourri3d and gdist packages, which will hopefully work fine on Mac and Python versions newer than 3.10.

The geodesic path calculation comes from potpourri3d, the distance matrix calulcation comes from gdist

Type of Change

  • Replaces backend functionality

How Has This Been Tested?

  • Unit tests
  • Benchmark notebook on synthetic data

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@jo-mueller jo-mueller added the enhancement New feature or request label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant