reduce massive logging when we req. recursive rows

via retrieveForeignRows and are not allowed to view all rows
campudus · Oct 20, 2023 · 44ae1b7 · 44ae1b7
1 parent 0f6730a
commit 44ae1b7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/main/scala/com/campudus/tableaux/database/model/TableauxModel.scala b/src/main/scala/com/campudus/tableaux/database/model/TableauxModel.scala
@@ -1248,7 +1248,9 @@ class TableauxModel(
   )(implicit user: TableauxUser): Future[Boolean] = {
     roleModel.checkAuthorization(
       ViewRow,
-      ComparisonObjects(permissions)
+      ComparisonObjects(permissions),
+      isInternalCall = false,
+      shouldLog = false
     ) transform {
       case Success(_) => Success(true)
       case Failure(_) => Success(false)

diff --git a/src/main/scala/com/campudus/tableaux/router/auth/permission/RoleModel.scala b/src/main/scala/com/campudus/tableaux/router/auth/permission/RoleModel.scala
@@ -59,7 +59,8 @@ class RoleModel(jsonObject: JsonObject) extends LazyLogging {
   def checkAuthorization(
       action: Action,
       objects: ComparisonObjects = ComparisonObjects(),
-      isInternalCall: Boolean = false
+      isInternalCall: Boolean = false,
+      shouldLog: Boolean = true
   )(implicit user: TableauxUser): Future[Unit] = {
 
     if (isInternalCall) {
@@ -71,7 +72,7 @@ class RoleModel(jsonObject: JsonObject) extends LazyLogging {
         Future.successful(())
       } else {
         val userName = user.name
-        logger.info(s"User ${userName} is not allowed to do action '$action'")
+        if (shouldLog) logger.info(s"User ${userName} is not allowed to do action '$action'")
         Future.failed(UnauthorizedException(action, userRoles))
       }
     }
@@ -411,7 +412,12 @@ class RoleModel(jsonObject: JsonObject) extends LazyLogging {
   */
 class RoleModelStub extends RoleModel(Json.emptyObj()) with LazyLogging {
 
-  override def checkAuthorization(action: Action, objects: ComparisonObjects, isInternalCall: Boolean)(
+  override def checkAuthorization(
+      action: Action,
+      objects: ComparisonObjects,
+      isInternalCall: Boolean,
+      shouldLog: Boolean
+  )(
       implicit user: TableauxUser
   ): Future[Unit] = {
     Future.successful(())