Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising row duplication behaviour #271

Merged
merged 8 commits into from
Oct 20, 2023

Conversation

hermann-p
Copy link
Contributor

Modifies the /tables/:tableId/rows/:rowId/duplicate endpoint to take options:

  • Optional JSON-body {columns: Array<{id: ColumnId}>} will duplicate only the values of those columns.
  • Optional boolean query parameter skipConstrainedLinks will skip duplicating values of link cells with constrained from-cardinality. When set, constrained link cell will not be duplicated, even if listed in the JSON-body payload.
  • Optional boolean query parameter annotateSkipped will add a check-me annotation to all cells whose values were not duplicated.

- `/duplicate?skipConstrainedLinks=true` will exempt links with `from`
  cardinality from duplication
- `/duplicate?annotateSkipped` will add `check-me` annotations to
  skipped columns
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Unit Test Results

951 tests  +4   943 ✔️ +4   5m 10s ⏱️ -3s
117 suites ±0       8 💤 ±0 
117 files   ±0       0 ±0 

Results for commit d5b3055. ± Comparison against base commit 4809444.

♻️ This comment has been updated with latest results.

@hermann-p hermann-p requested review from zingmane and Zwergal July 14, 2023 10:30
@hermann-p hermann-p force-pushed the customise-row-duplication branch from ffdf3ce to 242af47 Compare July 14, 2023 12:47
Copy link
Member

@zingmane zingmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

File Coverage
All files 88%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/arguments.scala 90%
com/campudus/tableaux/Starter.scala 74%
com/campudus/tableaux/cache/CacheVerticle.scala 76%
com/campudus/tableaux/cache/CacheClient.scala 68%
com/campudus/tableaux/controller/SystemController.scala 99%
com/campudus/tableaux/controller/TableauxController.scala 96%
com/campudus/tableaux/controller/StructureController.scala 91%
com/campudus/tableaux/controller/MediaController.scala 80%
com/campudus/tableaux/database/historyType.scala 8%
com/campudus/tableaux/database/languageType.scala 86%
com/campudus/tableaux/database/historyType.scala 64%
com/campudus/tableaux/database/database.scala 96%
com/campudus/tableaux/database/database.scala 81%
com/campudus/tableaux/database/database.scala 97%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 71%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/table.scala 96%
com/campudus/tableaux/database/domain/service.scala 62%
com/campudus/tableaux/database/domain/service.scala 0%
com/campudus/tableaux/database/domain/column.scala 77%
com/campudus/tableaux/database/domain/column.scala 48%
com/campudus/tableaux/database/domain/history.scala 81%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 0%
com/campudus/tableaux/database/domain/annotation.scala 80%
com/campudus/tableaux/database/domain/table.scala 99%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/file.scala 72%
com/campudus/tableaux/database/domain/domainobject.scala 99%
com/campudus/tableaux/database/domain/column.scala 92%
com/campudus/tableaux/database/domain/column.scala 78%
com/campudus/tableaux/database/domain/domainobject.scala 93%
com/campudus/tableaux/database/model/HistoryModel.scala 96%
com/campudus/tableaux/database/model/AttachmentModel.scala 82%
com/campudus/tableaux/database/model/TableauxModel.scala 93%
com/campudus/tableaux/database/model/StructureModel.scala 95%
com/campudus/tableaux/database/model/SystemModel.scala 84%
com/campudus/tableaux/database/model/FileModel.scala 94%
com/campudus/tableaux/database/model/structure/TableGroupModel.scala 79%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 89%
com/campudus/tableaux/database/model/structure/TableModel.scala 84%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 88%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 91%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 91%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 93%
com/campudus/tableaux/helper/FileUtils.scala 74%
com/campudus/tableaux/helper/JsonUtils.scala 94%
com/campudus/tableaux/helper/ResultChecker.scala 96%
com/campudus/tableaux/helper/IdentifierFlattener.scala 80%
com/campudus/tableaux/router/DocumentationRouter.scala 21%
com/campudus/tableaux/router/BaseRouter.scala 62%
com/campudus/tableaux/router/SystemRouter.scala 89%
com/campudus/tableaux/router/MediaRouter.scala 72%
com/campudus/tableaux/router/TableauxRouter.scala 83%
com/campudus/tableaux/router/StructureRouter.scala 99%
com/campudus/tableaux/router/RouterRegistry.scala 73%
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala 72%
com/campudus/tableaux/router/auth/permission/Condition.scala 89%
com/campudus/tableaux/router/auth/permission/Condition.scala 84%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 86%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 0%
com/campudus/tableaux/router/auth/permission/Condition.scala 90%
com/campudus/tableaux/router/auth/permission/Condition.scala 79%
com/campudus/tableaux/router/auth/permission/Action.scala 97%
com/campudus/tableaux/router/auth/permission/Condition.scala 85%
com/campudus/tableaux/router/auth/permission/TableauxUser.scala 63%
com/campudus/tableaux/verticles/JsonSchemaValidator/JsonSchemaValidator.scala 86%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against d5b3055

@zingmane zingmane merged commit 5adcd95 into master Oct 20, 2023
11 checks passed
@zingmane zingmane deleted the customise-row-duplication branch October 20, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants