AC#1033/fix-in-translation-endpoint

[zingmane]

Submit a pull request

Please make sure the following is true

• I gave the PR a meaningful name
• I checked that the correct target branch is selected
• I rebased the branch on the target branch and it can be merged
• I ran the linter and it did pass
• I checked for unused code / dead code / debug code
• I checked that variables/functions have meaningful names
• I checked that the behaviour is as the documentation/task describes and I tested it
• I updated the docs / specifications if possible
• I could explain all that code when someone wakes me up at 3am
• I checked that the code considers failures and not just the happy path
• There are no new dependencies OR I listed them and explained them below
• PR introduces no breaking changes OR I listed them and described them below
• I added/updated tests for new/modified unit-testable functions/helpers
• I ran the tests and they did pass

Other information/comments (e.g. reasons why points are not checked from above)

In dem Zuge hab ich auch das logging verbessert und im backend wird nicht mehr gelogged, wenn man eine Zeile per retrieveForeignRows nicht sehen darf. Durch die Rekursion und bei vielen Ausgangszeilen würde das nämlich die logs einfach nur voll spammen.

Das Dashboard hat mit der Änderung kein Problem mehr und rendert auch, wenn es nicht eine multicolumn Spalte gibt. Die Seite ist dann zwar witzlos, aber es wird auch nichts falsches angezeigt:

[github-actions]

File	Coverage
All files	88%	✅
com/campudus/tableaux/exceptions.scala	0%	❌
com/campudus/tableaux/exceptions.scala	0%	❌
com/campudus/tableaux/arguments.scala	90%	✅
com/campudus/tableaux/Starter.scala	74%	❌
com/campudus/tableaux/cache/CacheVerticle.scala	76%	❌
com/campudus/tableaux/cache/CacheClient.scala	68%	❌
com/campudus/tableaux/controller/SystemController.scala	99%	✅
com/campudus/tableaux/controller/TableauxController.scala	98%	✅
com/campudus/tableaux/controller/StructureController.scala	91%	✅
com/campudus/tableaux/controller/MediaController.scala	80%	✅
com/campudus/tableaux/database/historyType.scala	7%	❌
com/campudus/tableaux/database/languageType.scala	86%	✅
com/campudus/tableaux/database/historyType.scala	66%	❌
com/campudus/tableaux/database/database.scala	96%	✅
com/campudus/tableaux/database/database.scala	81%	✅
com/campudus/tableaux/database/database.scala	97%	✅
com/campudus/tableaux/database/domain/column.scala	68%	❌
com/campudus/tableaux/database/domain/column.scala	71%	❌
com/campudus/tableaux/database/domain/column.scala	95%	✅
com/campudus/tableaux/database/domain/table.scala	96%	✅
com/campudus/tableaux/database/domain/service.scala	62%	❌
com/campudus/tableaux/database/domain/service.scala	0%	❌
com/campudus/tableaux/database/domain/column.scala	77%	❌
com/campudus/tableaux/database/domain/column.scala	48%	❌
com/campudus/tableaux/database/domain/annotation.scala	0%	❌
com/campudus/tableaux/database/domain/history.scala	84%	✅
com/campudus/tableaux/database/domain/column.scala	68%	❌
com/campudus/tableaux/database/domain/column.scala	0%	❌
com/campudus/tableaux/database/domain/annotation.scala	83%	✅
com/campudus/tableaux/database/domain/annotation.scala	80%	✅
com/campudus/tableaux/database/domain/table.scala	99%	✅
com/campudus/tableaux/database/domain/column.scala	95%	✅
com/campudus/tableaux/database/domain/file.scala	72%	❌
com/campudus/tableaux/database/domain/domainobject.scala	99%	✅
com/campudus/tableaux/database/domain/column.scala	92%	✅
com/campudus/tableaux/database/domain/column.scala	78%	❌
com/campudus/tableaux/database/domain/domainobject.scala	93%	✅
com/campudus/tableaux/database/model/HistoryModel.scala	96%	✅
com/campudus/tableaux/database/model/AttachmentModel.scala	82%	✅
com/campudus/tableaux/database/model/TableauxModel.scala	94%	✅
com/campudus/tableaux/database/model/StructureModel.scala	95%	✅
com/campudus/tableaux/database/model/SystemModel.scala	84%	✅
com/campudus/tableaux/database/model/FileModel.scala	94%	✅
com/campudus/tableaux/database/model/structure/ColumnModel.scala	89%	✅
com/campudus/tableaux/database/model/structure/TableModel.scala	84%	✅
com/campudus/tableaux/database/model/structure/ColumnModel.scala	88%	✅
com/campudus/tableaux/database/model/structure/TableGroupModel.scala	79%	❌
com/campudus/tableaux/database/model/tableaux/RowModel.scala	93%	✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala	91%	✅
com/campudus/tableaux/database/model/tableaux/RowModel.scala	93%	✅
com/campudus/tableaux/helper/FileUtils.scala	74%	❌
com/campudus/tableaux/helper/JsonUtils.scala	94%	✅
com/campudus/tableaux/helper/ResultChecker.scala	98%	✅
com/campudus/tableaux/helper/IdentifierFlattener.scala	83%	✅
com/campudus/tableaux/router/DocumentationRouter.scala	21%	❌
com/campudus/tableaux/router/BaseRouter.scala	62%	❌
com/campudus/tableaux/router/SystemRouter.scala	89%	✅
com/campudus/tableaux/router/MediaRouter.scala	72%	❌
com/campudus/tableaux/router/TableauxRouter.scala	82%	✅
com/campudus/tableaux/router/StructureRouter.scala	99%	✅
com/campudus/tableaux/router/RouterRegistry.scala	54%	❌
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala	72%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	89%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	74%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	87%	✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala	87%	✅
com/campudus/tableaux/router/auth/permission/RoleModel.scala	0%	❌
com/campudus/tableaux/router/auth/permission/Condition.scala	90%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	79%	❌
com/campudus/tableaux/router/auth/permission/Action.scala	97%	✅
com/campudus/tableaux/router/auth/permission/Condition.scala	85%	✅
com/campudus/tableaux/router/auth/permission/TableauxUser.scala	63%	❌
com/campudus/tableaux/verticles/JsonSchemaValidator/JsonSchemaValidator.scala	86%	✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against d92756f

[github-actions]

Test Results

973 tests  +1   965 ✔️ +1   5m 16s ⏱️ +41s
120 suites ±0       8 💤 ±0 
120 files   ±0       0 ❌ ±0 

Results for commit d92756f. ± Comparison against base commit 0d75f59.

♻️ This comment has been updated with latest results.

[hermann-p]

LGTM. Ob dieser Edge-Case noch einen Test haben sollte?

[Zwergal]

lgtm