Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/tune-github-action #277

Closed
wants to merge 4 commits into from

Conversation

zingmane
Copy link
Member

Submit a pull request

Please make sure the following is true

  • I gave the PR a meaningful name
  • I checked that the correct target branch is selected
  • I rebased the branch on the target branch and it can be merged
  • I ran the linter and it did pass
  • I checked for unused code / dead code / debug code
  • I checked that variables/functions have meaningful names
  • I checked that the behaviour is as the documentation/task describes and I tested it
  • I updated the docs / specifications if possible
  • I could explain all that code when someone wakes me up at 3am
  • I checked that the code considers failures and not just the happy path
  • There are no new dependencies OR I listed them and explained them below
  • PR introduces no breaking changes OR I listed them and described them below
  • I added/updated tests for new/modified unit-testable functions/helpers
  • I ran the tests and they did pass

Other information/comments (e.g. reasons why points are not checked from above)

Reason for this PR

@zingmane zingmane marked this pull request as ready for review October 25, 2023 09:32
@zingmane zingmane force-pushed the chore/tune-github-action branch from a5204dc to 4f0c9f0 Compare October 25, 2023 09:33
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Test Results

985 tests   977 ✔️  4m 17s ⏱️
121 suites      8 💤
121 files        0

Results for commit 447bcd6.

♻️ This comment has been updated with latest results.

@zingmane zingmane force-pushed the chore/tune-github-action branch from ff601ba to 447bcd6 Compare October 25, 2023 10:11
@zingmane zingmane closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant