Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/filter-total-size-queries #286

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

zingmane
Copy link
Member

Wie in PR campudus/tableaux-frontend#381 erwähnt, sollte die totalSize von den Filtern abhängen und nicht nur die Kardinalität der Tabelle wiedergeben.
Siehe Comment Punkt #5: campudus/tableaux-frontend#381 (comment)

Copy link

github-actions bot commented May 17, 2024

Test Results

1 009 tests  ±0   1 001 ✅ ±0   2m 58s ⏱️ -14s
  124 suites ±0       8 💤 ±0 
  124 files   ±0       0 ❌ ±0 

Results for commit a446176. ± Comparison against base commit a5923a9.

♻️ This comment has been updated with latest results.

Copy link

File Coverage
All files 87%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/exceptions.scala 0%
com/campudus/tableaux/arguments.scala 90%
com/campudus/tableaux/Starter.scala 79%
com/campudus/tableaux/cache/CacheVerticle.scala 77%
com/campudus/tableaux/cache/CacheClient.scala 63%
com/campudus/tableaux/controller/SystemController.scala 99%
com/campudus/tableaux/controller/TableauxController.scala 98%
com/campudus/tableaux/controller/StructureController.scala 91%
com/campudus/tableaux/controller/MediaController.scala 80%
com/campudus/tableaux/database/historyType.scala 7%
com/campudus/tableaux/database/languageType.scala 86%
com/campudus/tableaux/database/historyType.scala 66%
com/campudus/tableaux/database/database.scala 96%
com/campudus/tableaux/database/database.scala 81%
com/campudus/tableaux/database/database.scala 97%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 71%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/table.scala 96%
com/campudus/tableaux/database/domain/service.scala 62%
com/campudus/tableaux/database/domain/service.scala 0%
com/campudus/tableaux/database/domain/column.scala 77%
com/campudus/tableaux/database/domain/annotation.scala 14%
com/campudus/tableaux/database/domain/column.scala 48%
com/campudus/tableaux/database/domain/annotation.scala 60%
com/campudus/tableaux/database/domain/history.scala 84%
com/campudus/tableaux/database/domain/column.scala 68%
com/campudus/tableaux/database/domain/column.scala 0%
com/campudus/tableaux/database/domain/annotation.scala 83%
com/campudus/tableaux/database/domain/annotation.scala 80%
com/campudus/tableaux/database/domain/table.scala 99%
com/campudus/tableaux/database/domain/column.scala 95%
com/campudus/tableaux/database/domain/file.scala 72%
com/campudus/tableaux/database/domain/domainobject.scala 99%
com/campudus/tableaux/database/domain/column.scala 92%
com/campudus/tableaux/database/domain/column.scala 78%
com/campudus/tableaux/database/domain/domainobject.scala 93%
com/campudus/tableaux/database/model/HistoryModel.scala 96%
com/campudus/tableaux/database/model/AttachmentModel.scala 82%
com/campudus/tableaux/database/model/TableauxModel.scala 91%
com/campudus/tableaux/database/model/StructureModel.scala 95%
com/campudus/tableaux/database/model/SystemModel.scala 84%
com/campudus/tableaux/database/model/FileModel.scala 94%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 89%
com/campudus/tableaux/database/model/structure/TableModel.scala 84%
com/campudus/tableaux/database/model/structure/TableGroupModel.scala 79%
com/campudus/tableaux/database/model/structure/ColumnModel.scala 88%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 91%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 92%
com/campudus/tableaux/database/model/tableaux/RowModel.scala 93%
com/campudus/tableaux/helper/FileUtils.scala 74%
com/campudus/tableaux/helper/JsonUtils.scala 94%
com/campudus/tableaux/helper/ResultChecker.scala 98%
com/campudus/tableaux/helper/IdentifierFlattener.scala 80%
com/campudus/tableaux/router/DocumentationRouter.scala 21%
com/campudus/tableaux/router/BaseRouter.scala 63%
com/campudus/tableaux/router/SystemRouter.scala 89%
com/campudus/tableaux/router/MediaRouter.scala 60%
com/campudus/tableaux/router/TableauxRouter.scala 82%
com/campudus/tableaux/router/StructureRouter.scala 99%
com/campudus/tableaux/router/RouterRegistry.scala 52%
com/campudus/tableaux/router/auth/KeycloakAuthHandler.scala 72%
com/campudus/tableaux/router/auth/permission/Condition.scala 89%
com/campudus/tableaux/router/auth/permission/Condition.scala 74%
com/campudus/tableaux/router/auth/permission/Condition.scala 87%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 87%
com/campudus/tableaux/router/auth/permission/RoleModel.scala 0%
com/campudus/tableaux/router/auth/permission/Condition.scala 90%
com/campudus/tableaux/router/auth/permission/Condition.scala 79%
com/campudus/tableaux/router/auth/permission/Action.scala 97%
com/campudus/tableaux/router/auth/permission/Condition.scala 85%
com/campudus/tableaux/router/auth/permission/TableauxUser.scala 63%
com/campudus/tableaux/verticles/JsonSchemaValidator/JsonSchemaValidator.scala 86%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 8c16a72

@zingmane zingmane changed the base branch from master to AC#1045/archive-rows May 17, 2024 15:45
@McHunkyTrunk McHunkyTrunk force-pushed the fix/filter-total-size-queries branch 3 times, most recently from d381902 to 534726c Compare May 21, 2024 10:45
@McHunkyTrunk McHunkyTrunk force-pushed the fix/filter-total-size-queries branch from 534726c to b5ac43b Compare May 21, 2024 10:51
@zingmane zingmane merged commit b40c0a8 into AC#1045/archive-rows Jun 19, 2024
6 checks passed
@zingmane zingmane deleted the fix/filter-total-size-queries branch June 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants